Skip to content

Commit

Permalink
BUGFIX: reimplement appendExceedingArguments for preview route
Browse files Browse the repository at this point in the history
This reintroduces

```yaml
appendExceedingArguments: true
```

for the preview route so that uris could still build via plain fusion or flows `Neos\Flow\Mvc\Routing\UriBuilder`

```
previewAction = Neos.Fusion:ActionUri {
  request = ${request.mainRequest}
  package = 'Neos.Neos'
  controller = 'Frontend\\\Node'
  action = 'preview'
  arguments = ${{node: someNodeAddress}}
}
```

This was initially reverted via 2c4670c in neos#4892 in effort to get slowly rid of the `appendExceedingArguments` ugliness. But in the Dresden sprint '24 was considered to big of a change for now, especially as there is no alternative to build the uris in fusion without the `queryParameters` option introduced for the `Neos.Fusion:ActionUri` which will only be part of: neos#3914
  • Loading branch information
mhsdesign committed Jan 6, 2025
1 parent c4eb48f commit 282d6c1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions Neos.Neos/Configuration/Routes.Frontend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
uriPattern: 'neos/preview'
defaults:
'@action': 'preview'
appendExceedingArguments: true

-
name: 'Default Frontend'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@ prototype(Neos.Workspace.Ui:Component.ReviewDocumentTableRow) < prototype(Neos.F
i18n = ${I18n.id('').source('Main').package('Neos.Workspace.Ui')}

openNodeInPreviewAction = Neos.Fusion:ActionUri {
request=${request.mainRequest}
package='Neos.Neos'
controller='Frontend\\\Node'
request = ${request.mainRequest}
package = 'Neos.Neos'
controller = 'Frontend\\\Node'
action = 'preview'
// todo fixme
@process.addQuery = ${value + '?node=' + document.document.documentNodeAddress}
arguments = ${{node: document.document.documentNodeAddress}}
}
discardDocumentAction = Neos.Fusion:ActionUri {
action = 'discardDocument'
Expand Down

0 comments on commit 282d6c1

Please sign in to comment.