Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add example for using local model wtth docker container #528

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

wirthual
Copy link
Collaborator

This question came up a few times already.

#527

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

@wirthual wirthual requested a review from michaelfeil February 10, 2025 15:59
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added a new section to the README.md demonstrating how to use local models with Docker containers, providing clear instructions for mounting and utilizing locally stored models in the Infinity framework.

  • Added example in README.md showing how to clone and mount HuggingFace models into Docker containers
  • Included command-line example for mounting local model directory using Docker volumes
  • Added explanation for using local models with the --model-id parameter

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires ‘git install git-lfs’ otherwise git clone won’t clone large files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. git lfs install ? https://git-lfs.com/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you added it already!

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (b17b588) to head (4709b8a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   79.86%   79.80%   -0.06%     
==========================================
  Files          43       43              
  Lines        3486     3486              
==========================================
- Hits         2784     2782       -2     
- Misses        702      704       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit b1c43db into main Feb 11, 2025
36 checks passed
@michaelfeil michaelfeil deleted the add-local-example branch February 11, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants