Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in read me, remove redundancy in compose file, and add Plugins.txt #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zanetworker
Copy link

@zanetworker zanetworker commented Jan 20, 2018

Fix typos in Readme:

  • Ports were set to 8080 instead of 8081 in dummy Jenkins container creation
  • Password was document as "password" instead "admin" was actually used

Redundancy in compose file:

  • replace data-containers with normal persistent volumes (data-containers add an extra level of dependancy and can cause glitches with containers which are later pruned)
  • remove directories for data-containers

Add Plugin.txt:

  • it can be useful to add a default plugin.txt for users who are not willing to create a dummy container only for the sake of getting the default plugins.

@michaellihs
Copy link
Owner

Hi @zanetworker - thanks for the feedback - with two sick women at home, I didn't have the time to come back to this any earlier :)

I have two questions:

  1. Will this volumes configuration in the compose file create a mounted volume on the host and mount it to the container (without any further tasks to be run on the host):

    volumes:
      jenkinsdata:
      jenkinsconf:
    
    #...
    
    services:
      jenkinsmaster:
        volumes:
          - jenkinsdata:/var/log/jenkins
          - jenkinsconf:/var/jenkins_home
  2. Did you see the jenkins-master/plugins.txt, since I think this is the same file as you created.

Besides, I "cherry picked" your changes manually - thanks a lot for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants