Lock yara-python at 4.2.3 bc 4.3.x causes problems

michelcrypt4d4mus · May 1, 2023 · acd2e77 · acd2e77
1 parent 27bef7c
commit acd2e77
Show file tree

Hide file tree

Showing 3 changed files with 94 additions and 128 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -44,7 +44,7 @@ chardet = "^5.0.0"
 python-dotenv = "^0.21.0"
 rich = "^12.5.1"
 rich-argparse-plus = "^0.3.1"
-yara-python = "^4.2.3"
+yara-python = "~4.2.3"
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^7.1.3"

diff --git a/tests/test_yaralyze.py b/tests/test_yaralyze.py
@@ -21,7 +21,7 @@
 def test_help_option():
     help_text = _run_with_args('-h')
     assert 'maximize-width' in help_text
-    _assert_line_count_within_range(127, help_text)
+    _assert_line_count_within_range(116, help_text)
 
 
 def test_no_rule_args(il_tulipano_path):
@@ -46,13 +46,13 @@ def test_yaralyze_with_files(il_tulipano_path, tulips_yara_path):
         yaralyze -Y tests/file_fixtures/tulips.yara tests/file_fixtures/il_tulipano_nero.txt
         yaralyze -dir tests/file_fixtures/ tests/file_fixtures/il_tulipano_nero.txt
     """
-    test_line_count = partial(_assert_output_line_count_is_close, 1002, il_tulipano_path)
+    test_line_count = partial(_assert_output_line_count_is_close, 948, il_tulipano_path)
     test_line_count('-Y', tulips_yara_path)
     test_line_count('-dir', path.dirname(tulips_yara_path))
 
 
 def test_yaralyze_with_patterns(il_tulipano_path, binary_file_path, tulips_yara_regex):
-    _assert_output_line_count_is_close(999, il_tulipano_path, '-re', tulips_yara_regex)
+    _assert_output_line_count_is_close(945, il_tulipano_path, '-re', tulips_yara_regex)
     _assert_output_line_count_is_close(90, binary_file_path, '-re', '3Hl0')
     _assert_output_line_count_is_close(96, binary_file_path, '-hex', HEX_STRING)
 
@@ -62,7 +62,7 @@ def test_file_export(binary_file_path, tulips_yara_path, tmp_dir):
     rendered_files = files_in_dir(tmp_dir)
     assert len(rendered_files) == 3
     file_sizes = [path.getsize(f) for f in rendered_files]
-    _assert_array_is_close(sorted(file_sizes), [62223, 106947, 307839])
+    _assert_array_is_close(sorted(file_sizes), [41677, 71115, 220090])
 
     for file in rendered_files:
         remove(file)