Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Accept uppercase LGTM as one of the default triggers #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Accept uppercase LGTM as one of the default triggers
Hi! I always forget the `lgtm` in the default trigger is lowercase. I know I can override the trigger but I'm thinking maybe you'll want to accept uppercase `LGTM` as one of the default triggers? Even this repository's description uses the uppercase variant in a few cases including the README picture so I think it might make sense? WDYT?

BTW as far as I can tell this shouldn't already work because the regex case-insensitive flag in the default input string is missing and `parseTrigger` doesn't add it but if it already does work maybe the problem is just with our setup. I don't use Go so I just followed what I learnt on SO in terms of how to make a pattern case-insensitive.
TomasHubelbauer authored Feb 28, 2023
commit 874bce4b74f2154a2a79f18732fcdb98ff1864bc
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ inputs:
trigger:
description: 'Trigger comment on issue to send reaction'
required: false
default: '["^lgtm$", "^[gG]ood [jJ]ob!?$"]'
default: '["(?i)^lgtm$", "^[gG]ood [jJ]ob!?$"]'
overide:
description: 'Whether the original comment is overridden'
required: false