Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in iOS Share Extension #76

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

vincentritter
Copy link
Collaborator

This fixes the issue with the crashing share extension. Reading the comments about "every second load crashes the app" is consistent to what we're seeing also — I thought it was a memory issue at first, but it was always the second time it loads up, after a successful load, that it crashes — all the time.

So this includes a fix, using: Expensify/react-native-share-menu#271

I also added fixes from here: Expensify/react-native-share-menu#295

I can confirm that the extension no longer crashes.

TODO: The Share extension is no longer working because we have commented it out in App.js — I can see why that was done, so will need to figure out how to bring it back — this is beyond this PR and will concentrate on Android in another release (which we're due to do).

@vincentritter vincentritter requested a review from manton March 7, 2024 10:55
@vincentritter
Copy link
Collaborator Author

Just for info @manton — once again I used bun but feel free to run it with yarn — because of the available patch, it would need to be applied running either bun install or yarn install — or yarn patch-package.

@manton
Copy link
Contributor

manton commented Mar 7, 2024

Excellent! Merging in. I think the Android thing I commented out temporarily… Should be safe to uncomment.

@manton manton merged commit 821ae70 into main Mar 7, 2024
@vincentritter vincentritter deleted the feature/share-sheet-two-point-ohhh branch March 19, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants