Add onnxsim to peephole optimizer #1602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jambayk
reviewed
Feb 7, 2025
| @@ -120,7 +120,7 @@ | |||
| "supported_providers": [ "*" ], | |||
| "supported_accelerators": [ "*" ], | |||
| "supported_precisions": [ "*" ], | |||
| "extra_dependencies": [ "onnxoptimizer", "onnxscript" ] | |||
| "extra_dependencies": [ "onnxoptimizer", "onnxscript", "onnxsmi" ] | |||
| return | ||
|
|
||
| self.model, check = simplify(self.model) | ||
| if not check: |
There was a problem hiding this comment.
From the source code, check is a Boolean whether the outputs of the original and simplified model match. So the message doesn't count correct.
Since it uses the default value of 0 for check_n, this is probably always be True.
| @@ -265,6 +276,7 @@ def _run_for_config( | |||
|
|
|||
| # optimize model | |||
| peephole_optimizer = ModelOptimizer(model.model_path) | |||
| peephole_optimizer.onnxsimplifier_optimize() | |||
There was a problem hiding this comment.
I think it might be better to move it after onnxscript. I don't think onnx simplifier handles dynamo exported model? If so, it's safer to put it after onnxscript.
| @@ -28,8 +28,8 @@ onnx-graphsurgeon | |||
| onnxconverter_common | |||
| onnxmltools | |||
| onnxoptimizer | |||
| onnxsim | |||
| # setup | ||
| input_model = get_onnx_model() | ||
| p = create_pass_from_dict(OnnxPeepholeOptimizer, {}, disable_search=True) | ||
| mock_onnxsim.return_value = input_model.load_model() |
There was a problem hiding this comment.
Expects a tuple of model and Boolean
|
Closing as will add implementation ourselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add onnxsim to peephole optimizer.
Checklist before requesting a review
lintrunner -a(Optional) Issue link