Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SqlServerDsc 17.0.0 and add coverage. #1414 #1415

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

addavenp1
Copy link
Collaborator

@addavenp1 addavenp1 commented Jan 25, 2025

Pull Request (PR) description:

  • Upgrade SqlServerDsc module to version 17.0.0
  • Added coverage for STIG Id V-213929
  • Added coverage for STIG Id V-213934
  • Added coverage for STIG Id V-213976
  • Added coverage for STIG Id V-213991

STIG Id V-213934 required a new parameter to be added to the SqlServer schema. The SqlPermission resource within SqlServerDsc module can't pass PSDscRunAsCredential to the resource. A new credential is required for the configuration to execute correctly.

This Pull Request (PR) fixes the following issues:

This fixes #1414

Task list:

  • [x ] Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • [x ] Added/updated documentation, comment-based help and descriptions where appropriate?
  • [x ] Examples appropriately updated?
  • [x ] New/changed code adheres to Style Guidelines?
  • [x ] Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@addavenp1 addavenp1 added the enhancement New feature or request label Jan 25, 2025
@addavenp1 addavenp1 added this to the 4.25.0 milestone Jan 25, 2025
@addavenp1
Copy link
Collaborator Author

addavenp1 commented Jan 25, 2025

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to SqlServerDsc 17.0.0 and add coverage
1 participant