Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: New module to perform audit only tasks for rules #738

Closed
wants to merge 3 commits into from

Conversation

IvanDrag0
Copy link

@IvanDrag0 IvanDrag0 commented Sep 2, 2020

Pull Request (PR) description:
New rule to allow the auditing of STIG rules that cannot be changed using DSC.
This Pull Request (PR) fixes the following issues:

This fixes #729

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • [] Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

The AuditOnlyRule takes in two new XML STIG properties:

Query = The Powershell query/command to run.
ExpectedValue = The value that is expected from the Powershell command.

If the Query matches the ExpectedValue, the resource marks it as in desired state.
@ghost
Copy link

ghost commented Sep 2, 2020

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

Codecov Report

Merging #738 into dev will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #738   +/-   ##
===================================
- Coverage    56%    56%   -1%     
===================================
  Files       126    127    +1     
  Lines      4323   4328    +5     
===================================
  Hits       2432   2432           
- Misses     1891   1896    +5     

@erjenkin
Copy link
Contributor

Current tests are in a failed state and PR has gone stale.

@erjenkin erjenkin closed this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using powershell to audit STIG rules
3 participants