-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement drop_while_view #1366
Conversation
Addresses #39 Some day i will remember to link it to the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a real review, just correcting the problem from #1393. (At least we're consistent.)
Thanks to STLs eagle eyes Co-authored-by: Casey Carter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - found a small batch of simple issues.
In my view, the remaining work for C++20 ranges will continue to drop while you continue to submit these amazing PRs. 😹 |
This implements drop_while_view.
Is solemnly swear that at some point in the future I will try to fully understand the magic @CaseyCarter has build with the Predicate and Semiregular_box stuff
Until then tests are green so ....