Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement drop_while_view #1366

Merged
merged 14 commits into from
Nov 6, 2020
Merged

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Oct 13, 2020

This implements drop_while_view.

Is solemnly swear that at some point in the future I will try to fully understand the magic @CaseyCarter has build with the Predicate and Semiregular_box stuff

Until then tests are green so ....

@miscco miscco requested a review from a team as a code owner October 13, 2020 12:59
@miscco
Copy link
Contributor Author

miscco commented Oct 13, 2020

Addresses #39

Some day i will remember to link it to the issue

@StephanTLavavej StephanTLavavej added cxx20 C++20 feature ranges C++20/23 ranges labels Oct 13, 2020
@CaseyCarter CaseyCarter self-assigned this Oct 14, 2020
@CaseyCarter CaseyCarter mentioned this pull request Oct 20, 2020
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a real review, just correcting the problem from #1393. (At least we're consistent.)

tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
miscco and others added 2 commits October 23, 2020 09:46
Thanks to STLs eagle eyes

Co-authored-by: Casey Carter <[email protected]>
tests/std/tests/P0896R4_views_drop_while/env.lst Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Oct 30, 2020
@StephanTLavavej StephanTLavavej self-assigned this Nov 3, 2020
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - found a small batch of simple issues.

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_drop_while/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Nov 4, 2020
stl/inc/ranges Outdated Show resolved Hide resolved
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej StephanTLavavej self-assigned this Nov 5, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej StephanTLavavej merged commit 1093aa6 into microsoft:master Nov 6, 2020
@StephanTLavavej
Copy link
Member

In my view, the remaining work for C++20 ranges will continue to drop while you continue to submit these amazing PRs. 😹

@miscco miscco deleted the drop_while branch November 7, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants