Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::find_first_of #821

Merged
merged 3 commits into from
May 14, 2020
Merged

Implement ranges::find_first_of #821

merged 3 commits into from
May 14, 2020

Conversation

CaseyCarter
Copy link
Member

Partially addresses #39.

@CaseyCarter CaseyCarter added the cxx20 C++20 feature label May 12, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner May 12, 2020 02:29
StephanTLavavej
StephanTLavavej approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although you need to resolve a merge conflict with yourself.

tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated Show resolved Hide resolved
mnatsuhara
mnatsuhara approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels nice to be back algorithms land 😄

stl/inc/algorithm Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this May 14, 2020
@StephanTLavavej StephanTLavavej merged commit 79c6021 into microsoft:master May 14, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing this algorithm - one step closer to range-ifying the world!

@CaseyCarter CaseyCarter deleted the find_first branch May 14, 2020 23:25
@CaseyCarter CaseyCarter mentioned this pull request Jun 11, 2020
Closed
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyCarter @StephanTLavavej @mnatsuhara