Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::search_n #914

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Implement ranges::search_n #914

merged 5 commits into from
Jun 30, 2020

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Jun 24, 2020 •
edited
Loading

Partially addresses #39.

(Note: #914, #915, and #916 contain identical changes to <range_algorithm_support.hpp>.)

@CaseyCarter CaseyCarter added the cxx20 C++20 feature label Jun 24, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner June 24, 2020 14:50
@CaseyCarter CaseyCarter mentioned this pull request Jun 24, 2020
Closed
This was referenced Jun 24, 2020
Merged
Merged
Merged
@cbezault cbezault self-assigned this Jun 24, 2020
mnatsuhara
mnatsuhara approved these changes Jun 25, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_search_n/test.cpp Outdated Show resolved Hide resolved
@cbezault cbezault removed their assignment Jun 26, 2020
StephanTLavavej
StephanTLavavej approved these changes Jun 26, 2020
View reviewed changes
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_search_n/test.cpp Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_search_n/test.cpp Show resolved Hide resolved
StephanTLavavej
StephanTLavavej requested changes Jun 27, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I should mark this as changes requested, even though the requests are small)

@CaseyCarter CaseyCarter mentioned this pull request Jun 27, 2020
Open
@CaseyCarter CaseyCarter self-assigned this Jun 29, 2020
@CaseyCarter CaseyCarter merged commit 021af3e into microsoft:master Jun 30, 2020
@CaseyCarter CaseyCarter deleted the search_n branch June 30, 2020 05:39
@CaseyCarter CaseyCarter removed their assignment Jun 30, 2020
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyCarter @StephanTLavavej @mnatsuhara @cbezault