Implement most ranges partition algorithms #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes `ranges::is_partitioned`, `ranges::partition`, `ranges::partition_copy`, and `ranges::partition_point`.
Closed
StephanTLavavej
changed the title
StephanTLavavej
requested changes
Jul 6, 2020
miscco
reviewed
Jul 6, 2020
miscco
reviewed
Jul 6, 2020
miscco
reviewed
Jul 6, 2020
CaseyCarter
commented
Jul 9, 2020
StephanTLavavej
approved these changes
Jul 10, 2020
cbezault
approved these changes
Jul 11, 2020
There was a problem hiding this comment.
The code doing the actual work and the tests look good to me.
I can't really say I have the deepest grasp on all the details of the templating for some of these functions but after staring at them for half an hour with the standard up they seem to make sense to me.
|
Thanks for implementing some of my favorite algorithms! 😸 Vaguely related historical trivia: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
ranges::is_partitioned,ranges::partition,ranges::partition_copy, andranges::partition_point.Partially addresses #39.