Defer checking subexpressions of binary expressions with known boolean result type #60865
+632
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Dec 28, 2024
| // Those boolean arguments wouldn't even have to be viable sources for type arguments being inferred. | ||
| // | ||
| // For those reasons, we defer obtaining the operand types here and checking the related errors. | ||
| checkNodeDeferred(node); |
There was a problem hiding this comment.
This is really the core of the fix. The rest of the PR only moves code around (for the most part)
| state.skip = true; | ||
| setLastResult(state, booleanType); | ||
| break; | ||
| case SyntaxKind.QuestionQuestionToken: |
There was a problem hiding this comment.
Out of curiosity (this may be a dumb question): Since SyntaxKind.EqualsToken (which I assume refers to assignment) is handled above and SyntaxKind.QuestionQuestionToken is handled here, should nullish coalescing assignment (SyntaxKind.QuestionQuestionEqualsToken) also be handled here?
There was a problem hiding this comment.
It's a valid question. I think no adjustments have to be made here though. Only = is permitted when the left side is a destructuring pattern. Other kinds of assignment~ operators in such scenarios result in a syntax error:
let a: number | undefined;
({ a } ??= { a: 10 }); // Uncaught SyntaxError: Invalid left-hand side in assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #60130
This PR removes the mechanism introduced in #54380 in favor of using the older
checkDeferredNodemechanism that allows the compiler to avoid an extra set of redundant errors.