Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting on ReFS volumes #1822

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

winstliu
Copy link
Member

@winstliu winstliu commented Oct 24, 2024

ReFS is the underlying filesystem that Dev Drives use and should be supported.

VFS for Git let ReFS drives through fine under https://github.com/microsoft/VFSForGit/releases/tag/v1.0.24074.1. I'm not sure why the volume check did not error out, but something changed and after installing the latest prereleases, existing enlistments on Dev Drives are now blocked. They should not be.

(git bisect did not find the issue, nor did I expect it to given this code path did not change)

ReFS is the underlying filesystem that dev drives use and should be supported.
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, and I am just as puzzled why this change was not required before.

@dscho dscho added this to the M196 milestone Oct 25, 2024
@dscho dscho merged commit c1c54e5 into microsoft:master Oct 25, 2024
5 checks passed
@winstliu winstliu deleted the user/winstonliu/allow-refs branch October 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants