Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL adding fixing bugs and adding new features #403

Merged
merged 12 commits into from
Feb 5, 2025
Merged

MySQL adding fixing bugs and adding new features #403

merged 12 commits into from
Feb 5, 2025

Conversation

nmalkapuram
Copy link
Contributor

@nmalkapuram nmalkapuram commented Nov 15, 2024 •
edited
Loading

Features:
Adding truncate database option to enable compete recipe for MYSQL.
Bug Fixes:
updated config files to not maintain replication logs, updated actual global values used to be consistent with the values passed in the profile.

yangpanMS
yangpanMS requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say recipe is that for ABC recipe? When you make behavior changes could you reflect the changes in the mysql document to explain what we are changing

@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch 2 times, most recently from 38a046b to d101531 Compare November 19, 2024 03:28
@nmalkapuram nmalkapuram marked this pull request as draft November 25, 2024 17:12
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch from d101531 to b162834 Compare November 29, 2024 07:46
@nmalkapuram nmalkapuram marked this pull request as ready for review November 29, 2024 08:38
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch from 9e9129b to 03f1b17 Compare December 2, 2024 10:45
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch from 03f1b17 to c15c2e6 Compare January 6, 2025 08:33
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch 2 times, most recently from afea188 to a6d5691 Compare February 3, 2025 12:57
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MySQLCompeteRecipe branch from a6d5691 to b8b403f Compare February 4, 2025 07:39
@nmalkapuram nmalkapuram changed the title Users/nmalkapuram/my sql compete recipe MySQL adding fixing bugs and adding new features Feb 4, 2025
@nmalkapuram nmalkapuram merged commit 6e06d45 into main Feb 5, 2025
5 checks passed
@nmalkapuram nmalkapuram deleted the users/nmalkapuram/MySQLCompeteRecipe branch February 5, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangpanMS yangpanMS yangpanMS approved these changes

@brdeyo brdeyo brdeyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmalkapuram @yangpanMS @brdeyo