Added null handling in scanner.ts #2015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting PR. We are interested in review this PR but we cannot take this immediately due to some other pending priority issues. We will take this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Null pointer exception when reading the scan results:
##[error][Exception]ErrorWithCause: An error occurred while scanning website page http://localhost:9009/
at Logger.trackExceptionAny (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:189664:29)
at Scanner. (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190823:29)
at Generator.next ()
at fulfilled (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190741:58)
caused by: TypeError: Cannot read property 'baseUrl' of undefined
at Scanner.getCombinedReportParameters (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190837:60)
at Scanner. (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190815:55)
at Generator.next ()
at fulfilled (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190741:58)
Accessibility scanning of URL http://localhost:9009/ completed
Motivation
Addresses #2014
Context
Pull request checklist
yarn test)<rootDir>/test-results/unit/coverageyarn precheckin)