Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service account authentication and ignore yarn config from environment variables #2186

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

v-viyada
Copy link
Contributor

@v-viyada v-viyada commented Sep 30, 2024

Details

This PR adjust the logic to set yarn config before installing runtime dependencies. It filters out environment variables starting with yarn_. This is to make Yarn commands for ado extension independent of any environment setting and if environment variable contains invalid/unrecognized variable starting with yarn_ than it throughs error. For example, environment YARN_MIN_VERSION (This is no valid config in yarn 3) will give below error:
Unrecognized or legacy configuration settings found: minVersion - run "yarn config -v" to see the list of settings supported in Yarn (in )

Also it updates accessibility insights scan package to fix the issue #2182.

Motivation
Context

Pull request checklist

@v-viyada v-viyada marked this pull request as ready for review September 30, 2024 19:12
@v-viyada v-viyada requested a review from a team as a code owner September 30, 2024 19:12
@v-viyada v-viyada enabled auto-merge (squash) September 30, 2024 20:25
@madalynrose
Copy link
Contributor

Closing and re-opening immediately to hopefully fetch license status properly.

@madalynrose madalynrose closed this Oct 1, 2024
auto-merge was automatically disabled October 1, 2024 15:58

Pull request was closed

@madalynrose madalynrose reopened this Oct 1, 2024
@DragosDanielBoia
Copy link
Member

@microsoft-github-policy-service agree

@v-viyada v-viyada merged commit 7c190be into main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] service account authentication failure for crawling urls #2569
3 participants