Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update node version to 20.x #2220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Update node version to 20.x #2220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: Install dependencies
run: yarn install --immutable
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: Install dependencies
run: yarn install --immutable
Expand Down
4 changes: 2 additions & 2 deletions packages/ado-extension/src/ado-extension-metadata.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ describe(AdoExtensionMetadataProvider, () => {
throw readFileError;
};

expect(() => testSubject.readMetadata()).toThrowError(readFileError);
expect(() => testSubject.readMetadata()).toThrow(readFileError);
});

it('throws an error if ado-extension-metadata.json is malformatted', () => {
mockFs.readFileSync = () => '{ "extensionName": "Oops it had some stray "quotes"" }';

expect(() => testSubject.readMetadata()).toThrowError(/Unexpected token/);
expect(() => testSubject.readMetadata()).toThrow("Expected ',' or '}' after property value in JSON at position 44");
});
});
2 changes: 1 addition & 1 deletion packages/ado-extension/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
}
],
"execution": {
"Node16": {
"Node20_1": {
"target": "index.js"
}
},
Expand Down
4 changes: 2 additions & 2 deletions pipelines/ado-extension-validation-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: '16.x'
displayName: Use Node 16.x
versionSpec: '20.x'
displayName: Use Node 20.x

# reused by all "url" cases
- script: npx serve "$(System.DefaultWorkingDirectory)/dev/website-root" -l 5858 &
Expand Down
8 changes: 4 additions & 4 deletions pipelines/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ extends:
steps:
- task: NodeTool@0
inputs:
versionSpec: '16.x'
displayName: Use Node 16.x
versionSpec: '20.x'
displayName: Use Node 20.x

- script: yarn install --immutable
displayName: Install dependencies
Expand Down Expand Up @@ -120,8 +120,8 @@ extends:
steps:
- task: NodeTool@0
inputs:
versionSpec: '16.x'
displayName: Use Node 16.x
versionSpec: '20.x'
displayName: Use Node 20.x

- script: yarn install --immutable
displayName: Install dependencies
Expand Down
Loading