Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lua support for fluent-bit #11009

Merged

Conversation

dmcilvaney
Copy link
Contributor

@dmcilvaney dmcilvaney commented Nov 11, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Updated version of #10690 with rebase against latest changes.

Change Log
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@dmcilvaney dmcilvaney requested a review from a team as a code owner November 11, 2024 19:10
@dmcilvaney dmcilvaney requested a review from paulmey November 11, 2024 19:21
@dmcilvaney dmcilvaney added 3.0-dev PRs Destined for AzureLinux 3.0 Packaging labels Nov 11, 2024
@eric-desrochers
Copy link
Contributor

eric-desrochers commented Nov 11, 2024

[Stable Maintainer note]
fluent-bit bump approved on 10/31 by the stable maintainer team. We will wait until all relevant approvers review the PR, then we (CBL-Mariner-Stable-Maintainers) will provide final review.

Copy link
Member

@paulmey paulmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcilvaney
Copy link
Contributor Author

Tested by running (some) of the bits here https://docs.fluentbit.io/manual/stream-processing/getting-started/hands-on

@dmcilvaney
Copy link
Contributor Author

Unclear why the buddybuild install test fails, I am able to install successfully.

@dmcilvaney
Copy link
Contributor Author

Unclear why the buddybuild install test fails, I am able to install successfully.

I re-checked on both the latest marketplace image and container, install seems fine.

@dmcilvaney dmcilvaney merged commit 684c696 into microsoft:3.0-dev Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants