You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.6.0-Daily-2019-07-17-01
Describe the bug
While using LG template in legacy dialogs like waterfall dialogs, incorrect/missing template name
could only be found in runtime which is a little bit suffer.
Except:
Have an indicator generator in VS Extension/VSCode Extension to generate all available template name list like this:
With this indicator, developers can easily refer the template name instead of hardcoded strings to reduce runtime error.
To Reproduce
Currently this is how we call LG in waterfall:
var result = await lgMultiLangEngine.Generate(turnContext, "[CancellingMessage]", null);
The [CancellingMessage] is a hardcoded string and can be easily misspelled. The code style with so many hardcoded strings is bad and when the template name is changed, it is easy to generate runtime error everywhere.
Expected behavior
Have a generator to help generate an indicator for a target LG file. And use LG like this:
var result = await lgMultiLangEngine.Generate(turnContext, SendEmailResponses.CancellingMessage , null);
The text was updated successfully, but these errors were encountered:
Ah, like LUISGen...auto generate a language binding string for all template names..
tomlm
changed the title
[Adaptive] [LG] Support LG template name indicator to translate LG run time error to compile error
[Adaptive] [LG] Create tooling to auto generate LG Template constnats from LG files
Aug 1, 2019
tomlm
changed the title
[Adaptive] [LG] Create tooling to auto generate LG Template constnats from LG files
[Adaptive] [LG] Create tooling to auto generate LG Template constants from LG files
Aug 1, 2019
tomlm
transferred this issue from microsoft/botbuilder-dotnet
Aug 1, 2019
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.6.0-Daily-2019-07-17-01
Describe the bug
While using LG template in legacy dialogs like waterfall dialogs, incorrect/missing template name
could only be found in runtime which is a little bit suffer.
Except:
Have an indicator generator in VS Extension/VSCode Extension to generate all available template name list like this:
With this indicator, developers can easily refer the template name instead of hardcoded strings to reduce runtime error.
To Reproduce
Currently this is how we call LG in waterfall:
var result = await lgMultiLangEngine.Generate(turnContext, "[CancellingMessage]", null);
The [CancellingMessage] is a hardcoded string and can be easily misspelled. The code style with so many hardcoded strings is bad and when the template name is changed, it is easy to generate runtime error everywhere.
Expected behavior
Have a generator to help generate an indicator for a target LG file. And use LG like this:
var result = await lgMultiLangEngine.Generate(turnContext, SendEmailResponses.CancellingMessage , null);
The text was updated successfully, but these errors were encountered: