Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

[DO NOT MERGE] Create New Tool LGgen #1283

Closed
wants to merge 11 commits into from

Conversation

haocheng-han
Copy link

Complete Issue #1235, create a new command line tool LGgen, now supports generating C#/TS variants.

Run the Tool

using commands like
dotnet LGgen.dll [-l cs/ts] [-n CLASS_NAME] [-c] [-i LG_FILE_PATH] [-o OUTPUT_PATH]
-l cs/ts : Select C# or Typescript, default to C#.
-i : LG file path or folder.
-o : Output path, defaults to directory where LG file is and the same name with LG file
-n : Designate class name, defaults to the same name of LG file
-c : Grammar check mode. You only need to input [-c] [-i LG_FILE_PATH] to run the grammar check.

Test

In LGgen_test, several usages are tested.

@hcyang hcyang changed the title Create New Tool LGgen [DO NOT MERGE] Create New Tool LGgen Sep 6, 2019
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LG CLI isn't ready for merging into master. Please reach out to me via email and lets sync.

@vishwacsena
Copy link
Contributor

This should get folded under the broader cli consolidation and should be part of the all up LG solution and should not go into master.

@cleemullins could we get this over to Jonathan since he is tracking the LG CLI effort?

@sgellock
Copy link
Member

sgellock commented Sep 9, 2019

@M-Gustuf thanks for the PR. There are a couple of things that need to be addressed before we can consider this. One this PR is against master. This tool is not yet in master and should be made against V.next. The second issue is this is written in C#. All CLI tooling needs to be written in JS or TS. I'm closing this PR out as I will assume you or someone from your team will issue a new PR

@sgellock sgellock closed this Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants