[test] Integrate Catnap Windows on CI Tool and Infrastructure #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbonde
reviewed
Nov 28, 2023
anandbonde
reviewed
Nov 28, 2023
anandbonde
reviewed
Nov 28, 2023
anandbonde
reviewed
Nov 28, 2023
anandbonde
reviewed
Nov 28, 2023
anandbonde
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Looks good. We should (at some point in future) unify the code for running tests and delegate the OS-specific functionality to lower levels of class hierarchy.
This will be important if we are going to maintain this infrastructure for a substantial amount of time in future.
ppenna
force-pushed
the
enhancement-ci-catnapw
branch
from
addca61 to
290ed90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #1031.
Additional Notes
Please, consider this a draft integration.
Related Issues