Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Add support for multiple ops to simulator and add new test #1430

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[testing] Add support for multiple ops to simulator and add new test #1430

merged 2 commits into from
Oct 8, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Oct 7, 2024 •
edited
Loading

This PR adds:

  1. Support for multiple ops in the simulator. It assumes that the waits are in the order that the ops are issued. Closes [simulator] Support multiple inflight requests #1427
  2. A new test for PR [inetstack] Bug Fix: Correct retransmission timer #1428 and issue [inetstack] Retransmit Timer Issues #202

@iyzhang iyzhang requested a review from anandbonde October 7, 2024 18:33
@iyzhang iyzhang self-assigned this Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

libos = catnap
commit id = 382d79e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 9722372.53 2065.95 922.64 32.87
demikernel::sgafree 11558.51 75.42 32.82 0.05
demikernel::sgaalloc 11339.55 118.17 53.00 0.12
ioc::network::libos::push;catnap::linux::transport::push 9066.08 772.55 350.02 4.83
ioc::network::libos::push 8800.47 16891.97 7633.16 7.18
demikernel::push 8800.47 534.95 240.28 0.16
ioc::network::libos::pop;catnap::linux::transport::pop 8026.21 573.67 253.25 4.27
ioc::network::libos::pop 7817.67 5195276.20 2171053.25 24.99
demikernel::pop 7817.67 546.94 240.41 0.12
ioc::network::libos::pushto 1482.67 8514.87 3555.27 24.30
ioc::network::libos::pushto;catnap::linux::transport::push 1482.67 683.23 285.66 7.90
demikernel::pushto 1482.67 576.24 241.02 1.72
demikernel::async_close 32.50 929.42 372.72 0.01
ioc::network::libos::connect 24.95 4393576.49 2035880.86 25.03
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 53338.02 24808.95 1.99
demikernel::connect 24.95 2114.54 988.44 0.01
ioc::network::libos::close 18.35 22366.67 9955.84 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 21372.38 9514.95 95.80
demikernel::accept 15.42 1334.65 590.84 0.00
ioc::network::libos::accept 15.41 891493486.08 393841412.55 44.76
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2709.40 1200.03 0.00
demikernel::socket 9.50 54403.82 24176.51 0.09
demikernel::socket;catnap::linux::transport::socket 9.50 52805.39 23466.75 97.26
demikernel::new 1.00 1619607.65 717522.95 0.61
demikernel::bind 1.00 29394.28 12940.10 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 23832.15 10496.71 80.91
demikernel::listen 1.00 14740.26 6496.73 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13725.39 6050.73 93.05
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

libos = catnip
commit id = 382d79e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 17096343.47 334.29 143.29 76.86
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 17096343.47 195.53 83.80 58.51
bgc::inetstack::poll_recv 8548171.73 870.17 372.94 33.38
bgc::inetstack::tcp::established::background 16479.79 2887.83 1240.04 0.34
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16479.79 869.18 372.42 30.69
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16458.89 1213.97 521.81 34.66
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16458.89 379.27 163.42 11.14
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16458.89 134.64 57.61 4.34
ioc::network::libos::pop 9042.53 732.83 316.77 0.05
demikernel::sgafree 8774.47 81.55 34.83 0.00
ioc::network::libos::push;inetstack::push 8762.74 2225.78 955.16 0.57
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.74 338.27 144.38 14.35
ioc::network::libos::push 8073.74 33602292.99 13507734.40 31.99
demikernel::push 8073.71 691.15 293.42 0.02
demikernel::sgaalloc 6529.17 123.83 52.00 0.00
demikernel::pop 6049.75 499.18 215.15 0.01
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3073.10 801.28 342.93 0.62
ioc::network::libos::pushto 1137.33 1411.20 569.28 0.06
ioc::network::libos::pushto;inetstack::push 1137.33 696.85 281.49 49.47
demikernel::pushto 1137.33 511.62 207.04 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1137.33 251.92 101.42 36.06
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 479.00 260.97 106.51 70.72
bgc::passive_listening::poll 58.61 5526.29 2405.56 0.00
ioc::network::libos::close 49.27 7800.45 3326.87 0.01
ioc::network::libos::connect 41.86 15621.45 6722.85 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 12836.49 5582.13 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 5895.64 2544.44 26.97
ioc::network::libos::accept 38.46 2475.62 1073.92 0.00
demikernel::async_close 32.50 546.17 230.00 0.00
ioc::network::libos::close;catnip::runtime::transmit 31.39 612.48 262.74 5.66
demikernel::accept 21.86 1394.87 602.11 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 15097.12 6555.01 38.92
demikernel::connect 20.93 3107.98 1330.46 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 20.93 696.79 300.22 4.57
demikernel::socket 10.30 1440.72 639.32 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 2433.78 1070.38 31.80
bgc::inetstack::arp::background 4.32 2076.03 892.57 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 19573.83 8395.03 95.51
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 17598.08 7548.51 89.87
bgc::inetstack::icmp::background 1.05 2922.57 1248.27 0.00
demikernel::new 1.00 1777111906.05 761650413.70 45.95
bgc::inetstack::poll_recv;inetstack::poll 1.00 40972.37 17572.77 0.17
demikernel::bind 1.00 22529.62 9649.97 0.00
demikernel::listen 1.00 6298.00 2739.31 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

libos = catpowder
commit id = 382d79e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 11003835.80 693.93 306.36 86.01
bgc::inetstack::poll_recv 5501917.90 1614.14 712.35 53.26
bgc::inetstack::tcp::established::background 16480.79 3771.39 1634.34 0.49
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16480.79 1397.09 585.62 32.81
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16461.07 1303.05 584.11 33.71
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16461.07 523.04 228.23 11.24
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16461.07 152.63 64.67 4.18
ioc::network::libos::pop 9030.61 843.94 376.93 0.07
ioc::network::libos::push;inetstack::push 8762.74 6174.56 2840.97 1.83
demikernel::sgafree 8749.19 89.15 39.33 0.01
ioc::network::libos::push 8073.76 33698155.79 14085596.17 43.00
demikernel::push 8073.71 669.91 303.23 0.04
demikernel::sgaalloc 6504.96 156.62 69.77 0.02
demikernel::pop 6034.75 650.55 284.26 0.03
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5277.68 692.78 302.22 0.73
ioc::network::libos::pushto 690.67 4626.82 1974.52 2.23
ioc::network::libos::pushto;inetstack::push 690.67 4083.93 1742.41 88.29
demikernel::pushto 690.67 515.27 220.40 0.24
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 192.00 272.50 118.75 67.68
bgc::passive_listening::poll 62.29 5089.99 2293.00 0.00
ioc::network::libos::close 46.18 10292.65 4514.50 0.15
ioc::network::libos::connect 41.86 21214.34 9580.20 0.18
bgc::inetstack::tcp::passiveopen::background 41.86 15373.65 7001.40 0.00
ioc::network::libos::accept 38.46 2535.24 1140.55 0.00
demikernel::async_close 32.50 801.67 316.92 0.01
demikernel::accept 21.86 1237.40 558.28 0.00
demikernel::connect 20.93 3524.02 1569.13 0.03
demikernel::socket 10.30 1541.76 657.68 0.00
bgc::inetstack::arp::background 4.03 1887.53 826.80 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5186.38 2283.11 81.72
bgc::inetstack::icmp::background 1.03 3478.92 1523.82 0.00
demikernel::new 1.00 90890874.97 40008240.97 18.53
demikernel::bind 1.00 23470.12 9753.63 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 12643.77 5564.20 0.05
demikernel::listen 1.00 6991.86 3095.59 0.00
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang force-pushed the enhancement-testing-simulator branch from 382d79e to 875410e Compare October 7, 2024 23:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

libos = catpowder
commit id = 875410e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 11130055.00 689.95 304.67 86.08
bgc::inetstack::poll_recv 5565027.50 1603.18 707.60 53.17
bgc::inetstack::tcp::established::background 16996.91 3623.41 1579.20 0.50
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16996.91 1345.00 564.75 33.05
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16977.36 1226.98 550.85 33.27
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16977.36 534.44 240.19 11.48
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16977.36 149.32 63.52 4.23
ioc::network::libos::pop 9182.90 904.06 403.69 0.07
ioc::network::libos::push;inetstack::push 8762.80 6557.82 3022.55 2.16
demikernel::sgafree 8754.70 111.07 49.19 0.01
ioc::network::libos::push 8073.76 33670818.77 15079502.90 42.71
demikernel::push 8073.74 595.73 269.68 0.04
demikernel::sgaalloc 6509.54 149.87 67.55 0.02
demikernel::pop 6038.10 605.13 267.24 0.03
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5543.22 636.06 279.55 0.67
ioc::network::libos::pushto 787.67 4383.54 1965.42 2.73
ioc::network::libos::pushto;inetstack::push 787.67 3856.95 1729.22 87.95
demikernel::pushto 787.67 479.75 215.27 0.28
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 272.67 208.71 92.76 63.11
bgc::passive_listening::poll 63.29 4911.46 2180.44 0.00
ioc::network::libos::close 46.42 10869.15 4793.36 0.13
ioc::network::libos::connect 41.86 21133.29 9653.11 0.15
bgc::inetstack::tcp::passiveopen::background 41.86 14790.14 6630.35 0.00
ioc::network::libos::accept 38.36 2507.19 1114.11 0.00
demikernel::async_close 32.50 658.45 264.69 0.01
demikernel::accept 21.86 1334.63 591.57 0.00
demikernel::connect 20.93 3239.17 1458.64 0.02
demikernel::socket 10.30 1581.09 695.84 0.00
bgc::inetstack::arp::background 4.12 1999.91 874.54 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5124.47 2261.54 81.52
bgc::inetstack::icmp::background 1.03 3397.67 1493.08 0.00
demikernel::new 1.00 85420347.80 37598180.36 18.81
demikernel::bind 1.00 22766.69 9676.04 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 12518.33 5519.23 0.04
demikernel::listen 1.00 6800.36 2985.71 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

libos = catnip
commit id = 875410e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 17193453.13 334.45 143.75 76.80
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 17193453.13 195.76 84.12 58.55
bgc::inetstack::poll_recv 8596726.57 871.31 374.47 33.32
bgc::inetstack::tcp::established::background 16480.09 2949.51 1260.52 0.34
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16480.09 907.83 387.56 30.88
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16459.16 1197.06 510.67 34.24
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16459.16 401.94 172.42 11.40
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16459.16 137.32 58.64 4.30
ioc::network::libos::pop 9044.92 745.89 319.47 0.05
demikernel::sgafree 8778.74 86.24 37.27 0.00
ioc::network::libos::push;inetstack::push 8762.69 2264.44 982.99 0.57
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.69 366.42 159.11 14.44
ioc::network::libos::push 8073.68 33602845.16 14668441.87 32.22
demikernel::push 8073.68 759.00 329.34 0.02
demikernel::sgaalloc 6535.25 131.10 57.04 0.00
demikernel::pop 6052.00 509.04 219.32 0.01
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3057.44 847.95 364.29 0.62
ioc::network::libos::pushto 1213.00 1429.89 619.59 0.06
ioc::network::libos::pushto;inetstack::push 1213.00 712.30 308.77 49.87
demikernel::pushto 1213.00 518.14 225.20 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1213.00 250.98 108.74 35.20
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 522.67 277.57 117.57 71.51
bgc::passive_listening::poll 59.36 5564.74 2417.21 0.00
ioc::network::libos::close 49.28 7773.29 3362.96 0.01
ioc::network::libos::connect 41.86 15500.77 6780.48 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 13799.61 6042.65 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 5675.60 2499.22 26.89
ioc::network::libos::accept 39.00 2376.88 1032.45 0.00
demikernel::async_close 32.50 546.55 230.36 0.00
ioc::network::libos::close;catnip::runtime::transmit 31.39 569.70 246.40 5.49
demikernel::accept 21.86 1420.99 616.23 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 15815.74 6984.15 38.86
demikernel::connect 20.93 2967.22 1293.17 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 20.93 775.19 336.39 4.54
demikernel::socket 10.30 1179.72 507.24 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 3808.67 1678.56 37.56
bgc::inetstack::arp::background 4.30 2195.71 943.13 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 19929.45 8560.21 95.38
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 17478.65 7518.27 88.85
bgc::inetstack::icmp::background 1.05 3139.52 1348.94 0.00
demikernel::new 1.00 1778947394.77 764641667.59 45.86
bgc::inetstack::poll_recv;inetstack::poll 1.00 41771.47 17941.59 0.17
demikernel::bind 1.00 23720.38 10038.16 0.00
demikernel::listen 1.00 6875.14 2942.46 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

libos = catnap
commit id = 875410e

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 9552197.53 2031.93 946.20 33.06
demikernel::sgafree 11535.67 74.23 32.53 0.05
demikernel::sgaalloc 11282.72 123.43 56.05 0.12
ioc::network::libos::push;catnap::linux::transport::push 9066.10 790.31 361.75 4.87
ioc::network::libos::push 8800.48 17075.73 7825.44 7.24
demikernel::push 8800.48 533.89 242.58 0.17
ioc::network::libos::pop;catnap::linux::transport::pop 8023.09 557.33 247.33 3.34
ioc::network::libos::pop 7814.63 9367715.15 3798989.39 24.96
demikernel::pop 7814.63 570.27 251.75 0.12
ioc::network::libos::pushto 591.00 7533.37 3126.39 22.85
ioc::network::libos::pushto;catnap::linux::transport::push 591.00 563.60 234.14 7.49
demikernel::pushto 591.00 448.87 186.32 1.37
demikernel::async_close 32.50 879.12 339.26 0.01
ioc::network::libos::connect 24.95 4620778.57 2085162.02 25.69
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 51534.35 23580.40 1.81
demikernel::connect 24.95 2102.36 959.36 0.01
ioc::network::libos::close 18.35 22398.91 9980.83 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 21285.20 9484.81 95.52
demikernel::accept 15.42 1453.95 647.82 0.00
ioc::network::libos::accept 15.39 888795788.52 402944450.22 44.25
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2974.15 1333.54 0.00
demikernel::socket 9.50 52876.35 23577.61 0.08
demikernel::socket;catnap::linux::transport::socket 9.50 51179.84 22814.57 97.13
demikernel::new 1.00 1619091.56 721169.05 0.53
demikernel::bind 1.00 28441.45 12582.31 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 22699.15 10049.36 80.18
demikernel::listen 1.00 14236.66 6305.39 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13261.03 5875.58 93.08
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang merged commit 8293d33 into dev Oct 8, 2024
14 checks passed
@iyzhang iyzhang deleted the enhancement-testing-simulator branch October 8, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

Assignees

@iyzhang iyzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[simulator] Support multiple inflight requests
2 participants
@iyzhang @anandbonde