Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Enhancement: Two new tests for pop #1445

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Oct 21, 2024

This PR adds two basic tests for pop:

  1. A duplicate packet arrives before the ack goes out.
  2. A packet arrives out of order before the previous packet or the ack (and causing an ack).

@iyzhang iyzhang requested a review from anandbonde October 21, 2024 18:27
@iyzhang iyzhang self-assigned this Oct 21, 2024
Copy link

libos = catnap
commit id = 286e19b

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 9729486.32 1886.29 823.05 32.14
demikernel::sgafree 11534.26 76.17 32.76 0.05
demikernel::sgaalloc 11281.92 126.40 54.24 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.10 737.43 322.41 4.69
ioc::network::libos::push 8800.48 16581.62 7260.68 6.16
demikernel::push 8800.48 526.30 228.89 0.14
ioc::network::libos::pop;catnap::linux::transport::pop 8023.01 532.89 231.73 1.03
ioc::network::libos::pop 7814.56 13701912.38 5815012.52 25.17
demikernel::pop 7814.56 556.87 239.31 0.11
ioc::network::libos::pushto 536.67 7555.06 3224.61 25.48
ioc::network::libos::pushto;catnap::linux::transport::push 536.67 560.44 239.15 7.42
demikernel::pushto 536.67 447.68 191.04 1.49
demikernel::async_close 32.50 948.38 378.01 0.02
ioc::network::libos::connect 24.95 6201373.19 2651946.05 30.35
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 60165.90 25974.44 2.12
demikernel::connect 24.95 2321.52 1002.36 0.01
ioc::network::libos::close 18.35 23856.75 10293.34 0.08
ioc::network::libos::close;catnap::linux::transport::close 18.35 22964.04 9908.62 96.32
demikernel::accept 15.42 1336.62 579.81 0.00
ioc::network::libos::accept 15.39 904144020.26 393902573.12 44.50
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2630.94 1149.57 0.00
demikernel::socket 9.50 127703.47 55294.59 0.22
demikernel::socket;catnap::linux::transport::socket 9.50 125927.69 54514.78 97.05
demikernel::new 1.00 245445.48 106011.64 0.14
demikernel::bind 1.00 27393.12 11901.15 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 23017.65 10003.44 83.97
demikernel::listen 1.00 14231.92 6185.81 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13114.68 5700.18 92.12
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catpowder
commit id = 286e19b

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 11145494.30 681.30 294.03 86.07
bgc::inetstack::poll_recv 5572747.15 1584.24 683.68 53.12
bgc::inetstack::tcp::established::background 18347.23 3817.31 1645.13 0.54
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 18347.23 1479.16 629.12 33.28
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 18327.18 1268.73 548.23 33.31
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 18327.18 494.96 221.42 10.97
bgc::inetstack::tcp::established::background;tcp::established::background::sender 18327.18 162.95 70.13 4.47
ioc::network::libos::pop 9516.47 944.03 407.38 0.09
ioc::network::libos::push;inetstack::push 8762.80 6192.42 2696.70 1.73
demikernel::sgafree 8750.04 127.65 55.28 0.01
ioc::network::libos::push 8073.97 33648267.75 15259303.36 42.96
demikernel::push 8073.74 579.09 249.85 0.04
demikernel::sgaalloc 6504.67 143.14 61.79 0.02
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 6185.54 631.86 273.42 0.68
demikernel::pop 6035.14 568.79 244.93 0.03
ioc::network::libos::pushto 705.33 4775.43 2170.47 2.78
ioc::network::libos::pushto;inetstack::push 705.33 4194.68 1906.53 87.85
demikernel::pushto 705.33 537.12 244.33 0.30
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 209.33 260.02 116.47 66.87
bgc::passive_listening::poll 62.86 5270.66 2277.13 0.00
ioc::network::libos::close 47.05 10216.49 4376.46 0.14
ioc::network::libos::connect 41.86 21310.28 9207.73 0.16
bgc::inetstack::tcp::passiveopen::background 41.86 15228.58 6566.14 0.00
ioc::network::libos::accept 38.39 2543.00 1099.10 0.00
demikernel::async_close 32.50 743.41 316.68 0.01
demikernel::accept 21.86 1301.59 563.01 0.00
demikernel::connect 20.93 3953.77 1714.26 0.02
demikernel::socket 10.30 2239.25 969.84 0.00
bgc::inetstack::arp::background 4.12 1826.41 789.92 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5520.78 2377.06 81.08
bgc::inetstack::icmp::background 1.03 3404.43 1465.58 0.00
demikernel::new 1.00 90657683.27 39159316.36 18.63
demikernel::bind 1.00 24950.38 11002.12 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 13545.40 5834.60 0.04
demikernel::listen 1.00 5804.64 2502.04 0.00
demikernel::close 0.00 nan nan 0.00

Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

libos = catnip
commit id = 286e19b

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 17065573.07 332.21 138.27 76.99
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 17065573.07 194.16 80.75 58.47
bgc::inetstack::poll_recv 8532786.53 863.32 359.42 33.47
bgc::inetstack::tcp::established::background 16480.14 2904.17 1215.52 0.34
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16480.14 857.80 352.02 30.32
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16459.21 1212.09 514.46 34.24
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16459.21 380.89 161.22 11.37
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16459.21 134.10 54.66 4.37
ioc::network::libos::pop 9046.96 750.92 316.39 0.05
demikernel::sgafree 8846.28 87.93 36.63 0.00
ioc::network::libos::push;inetstack::push 8762.80 2299.94 980.73 0.57
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 352.61 149.50 14.13
ioc::network::libos::push 8073.74 33627321.51 13629989.12 32.49
demikernel::push 8073.74 799.87 334.73 0.02
demikernel::sgaalloc 6679.33 146.49 61.17 0.01
demikernel::pop 6053.67 512.05 213.58 0.01
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3046.36 809.34 338.14 0.56
ioc::network::libos::pushto 2405.67 1411.77 580.24 0.14
ioc::network::libos::pushto;inetstack::push 2405.67 679.55 279.63 48.22
demikernel::pushto 2405.67 478.29 196.42 0.05
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 2405.67 250.28 103.19 36.70
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 551.00 298.82 118.94 74.60
bgc::passive_listening::poll 58.00 5574.70 2334.02 0.00
ioc::network::libos::close 49.20 7858.33 3286.06 0.01
ioc::network::libos::connect 41.86 15766.13 6678.20 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 13974.14 5870.87 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6127.32 2595.32 28.30
ioc::network::libos::accept 38.32 2455.61 1028.30 0.00
demikernel::async_close 32.50 568.90 226.32 0.00
ioc::network::libos::close;catnip::runtime::transmit 31.39 616.00 257.88 5.60
demikernel::accept 21.86 1239.20 518.05 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 17090.74 7185.03 40.50
demikernel::connect 20.93 2575.66 1090.92 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 20.93 753.75 314.81 4.85
demikernel::socket 10.30 1219.57 506.94 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 1690.00 703.89 26.92
bgc::inetstack::arp::background 4.30 2097.20 872.37 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 20565.45 8554.08 95.55
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 18296.98 7609.31 88.99
bgc::inetstack::icmp::background 1.05 3383.98 1410.00 0.00
demikernel::new 1.00 1781326255.08 740655119.07 45.53
bgc::inetstack::poll_recv;inetstack::poll 1.00 43036.33 17900.07 0.13
demikernel::bind 1.00 11655.50 4799.64 0.00
demikernel::listen 1.00 5208.50 2162.34 0.00
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang merged commit fd5a412 into dev Oct 29, 2024
14 checks passed
@iyzhang iyzhang deleted the enhancement-testing-pop-tests branch October 29, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants