Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collections] Bug Fix: Increasing arbitrary timeout #1450

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Oct 30, 2024

This PR increases an arbitrary timeout in our data structures to keep our slower libOSes from timing out.

@iyzhang iyzhang requested a review from anandbonde October 30, 2024 18:25
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iyzhang iyzhang force-pushed the bugfix-collections-timeout branch from ca0352c to 3cb8b48 Compare October 30, 2024 20:41
Copy link

libos = catnap
commit id = 3cb8b48

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13249093.37 1894.47 822.75 32.02
demikernel::sgafree 11545.09 73.42 31.47 0.04
demikernel::sgaalloc 11297.08 121.76 52.36 0.09
ioc::network::libos::push;catnap::linux::transport::push 9066.12 754.08 332.18 4.69
ioc::network::libos::push 8800.49 17085.03 7502.93 5.84
demikernel::push 8800.49 613.71 268.06 0.15
ioc::network::libos::pop;catnap::linux::transport::pop 8029.26 657.82 284.37 2.32
ioc::network::libos::pop 7820.64 8415905.05 3470075.88 27.07
demikernel::pop 7820.64 580.13 251.41 0.10
ioc::network::libos::pushto 958.67 10852.99 4426.16 28.11
ioc::network::libos::pushto;catnap::linux::transport::push 958.67 979.73 399.54 9.09
demikernel::pushto 958.67 465.71 189.80 1.09
demikernel::async_close 32.50 911.59 381.54 0.01
ioc::network::libos::connect 24.95 6248182.12 2700863.90 26.55
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 58650.62 25834.50 1.88
demikernel::connect 24.95 2327.50 1032.10 0.01
ioc::network::libos::close 18.35 24271.21 10596.87 0.07
ioc::network::libos::close;catnap::linux::transport::close 18.35 23278.88 10166.19 96.16
demikernel::accept 15.42 1508.79 659.21 0.00
ioc::network::libos::accept 15.41 879558922.29 383244800.00 44.48
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2570.16 1121.62 0.00
demikernel::socket 9.50 128471.39 57734.17 0.20
demikernel::socket;catnap::linux::transport::socket 9.50 127020.75 57095.91 97.60
demikernel::new 1.00 268754.42 116863.41 0.12
demikernel::bind 1.00 27274.10 11919.69 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 22924.18 10018.30 83.96
demikernel::listen 1.00 16318.95 7164.33 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 15384.13 6757.16 93.89
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catpowder
commit id = 3cb8b48

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 18952669.80 677.89 288.43 86.45
bgc::inetstack::poll_recv 9476334.90 1568.72 667.47 51.92
bgc::inetstack::tcp::established::background 16480.96 3548.25 1515.15 0.50
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16480.96 1268.71 529.14 32.02
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16461.59 1244.49 538.11 33.72
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16461.59 506.41 224.55 11.59
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16461.59 152.24 64.07 4.40
ioc::network::libos::pop 9034.10 914.97 396.99 0.09
ioc::network::libos::push;inetstack::push 8762.80 6162.85 2665.35 2.02
demikernel::sgafree 8753.45 117.97 51.38 0.01
ioc::network::libos::push 8073.74 33640241.86 14616915.59 42.13
demikernel::push 8073.74 582.56 251.22 0.04
demikernel::sgaalloc 6506.71 130.26 55.49 0.02
demikernel::pop 6038.63 639.27 272.16 0.05
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5281.71 599.88 255.94 0.65
ioc::network::libos::pushto 765.67 4675.18 2002.63 2.70
ioc::network::libos::pushto;inetstack::push 765.67 4086.24 1751.08 87.44
demikernel::pushto 765.67 496.62 212.89 0.28
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 270.67 229.67 100.51 63.51
bgc::passive_listening::poll 61.93 5038.88 2164.36 0.00
ioc::network::libos::close 45.85 10550.52 4478.16 0.15
ioc::network::libos::connect 41.86 22091.63 9455.94 0.16
bgc::inetstack::tcp::passiveopen::background 41.86 14164.42 6133.78 0.00
ioc::network::libos::accept 38.21 2492.95 1074.76 0.00
demikernel::async_close 32.50 693.59 289.81 0.01
demikernel::accept 21.86 1207.62 516.90 0.00
demikernel::connect 20.93 3719.56 1594.95 0.02
demikernel::socket 10.30 1411.97 608.65 0.00
bgc::inetstack::arp::background 6.30 1794.37 763.95 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5546.62 2359.65 83.27
bgc::inetstack::icmp::background 1.03 3247.57 1381.06 0.00
demikernel::new 1.00 95800325.75 40693375.08 20.39
demikernel::bind 1.00 26144.31 11126.88 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 13253.73 5638.32 0.05
demikernel::listen 1.00 5772.93 2455.34 0.00
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnip
commit id = 3cb8b48

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 28599098.67 333.48 138.88 76.68
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 28599098.67 194.46 80.97 58.34
bgc::inetstack::poll_recv 14299549.33 870.04 362.32 33.39
bgc::inetstack::tcp::established::background 16480.20 2875.87 1192.07 0.33
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 16480.20 863.66 353.40 30.77
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 16459.27 1174.87 491.04 33.76
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 16459.27 388.05 162.24 11.48
bgc::inetstack::tcp::established::background;tcp::established::background::sender 16459.27 130.37 53.30 4.25
ioc::network::libos::pop 9044.51 775.78 325.51 0.05
demikernel::sgafree 8780.66 84.68 35.22 0.00
ioc::network::libos::push;inetstack::push 8762.80 2268.30 955.61 0.58
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 353.09 147.00 14.64
ioc::network::libos::push 8073.76 33619896.85 12388530.81 32.34
demikernel::push 8073.74 754.03 308.63 0.02
demikernel::sgaalloc 6537.54 140.20 57.10 0.00
demikernel::pop 6051.71 509.05 212.86 0.01
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3051.71 811.92 337.43 0.60
ioc::network::libos::pushto 1246.33 1401.05 580.39 0.06
ioc::network::libos::pushto;inetstack::push 1246.33 701.62 290.70 50.22
demikernel::pushto 1246.33 480.81 199.42 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1246.33 257.98 106.83 36.72
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 535.33 274.82 114.41 72.02
bgc::passive_listening::poll 59.04 5487.89 2341.67 0.00
ioc::network::libos::close 49.17 7803.41 3249.17 0.01
ioc::network::libos::connect 41.86 15307.09 6377.79 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 13976.68 6074.56 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 5786.85 2410.44 27.32
ioc::network::libos::accept 38.86 2414.52 1034.41 0.00
demikernel::async_close 32.50 571.22 230.40 0.00
ioc::network::libos::close;catnip::runtime::transmit 31.39 643.79 267.60 5.60
demikernel::accept 21.86 1058.11 451.65 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 16035.46 7064.41 38.68
demikernel::connect 20.93 2585.88 1074.32 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 20.93 732.11 307.25 4.69
demikernel::socket 10.30 1521.11 640.29 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 3724.00 1549.20 40.90
bgc::inetstack::arp::background 6.57 2207.85 921.34 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 20237.38 8429.59 95.56
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 18011.27 7503.06 88.98
bgc::inetstack::icmp::background 1.05 3308.18 1376.94 0.00
demikernel::new 1.00 1768715602.18 736321303.88 45.72
bgc::inetstack::poll_recv;inetstack::poll 1.00 42352.07 17637.96 0.16
demikernel::bind 1.00 11407.62 4786.62 0.00
demikernel::listen 1.00 5273.43 2207.84 0.00
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang merged commit bf69f14 into dev Oct 30, 2024
14 checks passed
@iyzhang iyzhang deleted the bugfix-collections-timeout branch October 30, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants