Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inetstack] Bug Fix: Remove ack queue #1452

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 1, 2024

The ack queue is no longer needed to block push operations until the other end acks. Instead, we now wait for the ack sequence number to rise above the sequence number assigned to the buffer range that we pushed.

@iyzhang iyzhang requested a review from anandbonde November 1, 2024 22:11
Copy link

github-actions bot commented Nov 1, 2024

libos = catnap
commit id = 3c81ce2

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13481388.60 1898.86 822.60 32.13
demikernel::sgafree 11577.34 75.92 32.43 0.04
demikernel::sgaalloc 11347.08 125.93 53.69 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.10 782.75 342.19 4.79
ioc::network::libos::push 8800.48 16812.16 7380.77 5.62
demikernel::push 8800.48 577.73 252.41 0.14
ioc::network::libos::pop;catnap::linux::transport::pop 8045.47 524.19 228.07 1.66
ioc::network::libos::pop 7836.43 3783123.83 1583952.61 25.95
demikernel::pop 7836.43 580.74 250.90 0.10
ioc::network::libos::pushto 2216.67 9252.66 3843.12 27.47
ioc::network::libos::pushto;catnap::linux::transport::push 2216.67 583.12 242.05 6.47
demikernel::pushto 2216.67 499.17 207.35 1.56
demikernel::async_close 32.50 915.09 374.74 0.01
ioc::network::libos::connect 24.95 7310012.58 3100248.79 29.37
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 55186.38 23578.92 1.46
demikernel::connect 24.95 2207.52 945.78 0.01
ioc::network::libos::close 18.35 23381.76 10112.85 0.05
ioc::network::libos::close;catnap::linux::transport::close 18.35 22471.72 9719.72 96.33
demikernel::accept 15.42 1358.89 598.11 0.00
ioc::network::libos::accept 15.39 923052864.35 407250809.63 44.88
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2935.24 1275.74 0.00
demikernel::socket 9.50 125409.94 54197.66 0.16
demikernel::socket;catnap::linux::transport::socket 9.50 123655.67 53432.15 97.23
demikernel::new 1.00 256185.35 111035.16 0.06
demikernel::bind 1.00 31919.35 13908.92 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 27202.62 11848.94 83.94
demikernel::listen 1.00 14964.63 6544.72 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13974.71 6112.56 93.28
demikernel::close 0.00 nan nan 0.00

Copy link

github-actions bot commented Nov 1, 2024

libos = catpowder
commit id = 3c81ce2

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 18937551.07 680.47 294.39 86.10
bgc::inetstack::poll_recv 9468775.53 1581.34 684.18 52.38
bgc::inetstack::tcp::established::background 22047.71 4018.38 1753.60 0.91
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 22047.71 430.57 188.25 9.02
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 22038.68 879.95 383.12 22.11
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 22009.05 1078.46 466.18 22.13
bgc::inetstack::tcp::established::background;tcp::established::background::sender 21967.14 1892.89 833.89 37.45
ioc::network::libos::pop 9030.20 983.70 422.55 0.08
ioc::network::libos::push;inetstack::push 8762.80 673.55 296.68 0.21
demikernel::sgafree 8758.96 106.21 47.12 0.01
ioc::network::libos::push 8073.74 33630629.32 19637046.15 42.62
demikernel::push 8073.74 570.15 253.12 0.04
demikernel::sgaalloc 6524.54 141.53 64.38 0.02
demikernel::pop 6035.06 591.65 253.95 0.03
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5278.63 617.77 271.56 0.72
ioc::network::libos::pushto 863.00 5364.70 2209.58 3.73
ioc::network::libos::pushto;inetstack::push 863.00 4747.56 1955.48 88.38
demikernel::pushto 863.00 593.35 244.39 0.40
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 207.33 260.12 112.88 63.90
ioc::network::libos::close 48.12 6568.51 2861.19 0.11
bgc::passive_listening::poll 44.89 5662.68 2447.44 0.00
ioc::network::libos::connect 41.86 19736.62 8675.31 0.17
bgc::inetstack::tcp::passiveopen::background 41.86 15278.30 6579.56 0.00
ioc::network::libos::accept 38.11 2740.92 1189.46 0.00
demikernel::async_close 32.50 705.01 310.50 0.01
demikernel::accept 21.86 1260.67 544.29 0.00
demikernel::connect 20.93 3604.46 1605.17 0.03
demikernel::socket 10.30 2159.33 921.51 0.00
bgc::inetstack::arp::background 6.38 1878.60 817.33 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5263.62 2277.30 82.32
bgc::inetstack::icmp::background 1.03 3495.35 1513.46 0.00
demikernel::new 1.00 91338394.62 39700231.77 19.21
demikernel::bind 1.00 25304.56 11593.15 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 12717.07 5503.34 0.03
demikernel::listen 1.00 7481.50 3211.62 0.00
demikernel::close 0.00 nan nan 0.00

Copy link

github-actions bot commented Nov 1, 2024

libos = catnip
commit id = 3c81ce2

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 29018785.87 330.64 138.22 76.78
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 29018785.87 194.18 81.16 58.76
bgc::inetstack::poll_recv 14509392.93 861.82 360.41 34.63
bgc::inetstack::tcp::established::background 22053.57 2708.72 1148.81 0.45
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 22053.57 332.54 142.32 11.76
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 22041.95 590.77 245.37 22.78
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 22009.66 1000.16 425.87 29.52
bgc::inetstack::tcp::established::background;tcp::established::background::sender 21967.66 743.91 310.43 22.09
ioc::network::libos::pop 9045.14 881.76 373.76 0.06
demikernel::sgafree 8814.51 81.94 34.77 0.00
ioc::network::libos::push;inetstack::push 8762.80 649.68 279.86 0.16
ioc::network::libos::push 8073.74 33633071.52 13619023.66 32.28
demikernel::push 8073.74 726.36 306.53 0.02
demikernel::sgaalloc 6612.83 138.99 58.30 0.01
demikernel::pop 6052.12 552.86 232.44 0.01
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 5497.68 394.10 163.97 15.45
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3627.56 733.71 309.17 0.71
ioc::network::libos::pushto 1844.33 1416.52 569.06 0.10
ioc::network::libos::pushto;inetstack::push 1844.33 709.54 285.05 50.15
demikernel::pushto 1844.33 493.56 198.26 0.04
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1844.33 258.98 104.07 36.21
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 535.33 254.12 102.70 70.95
ioc::network::libos::close 49.33 6287.80 2633.49 0.01
bgc::passive_listening::poll 42.21 6352.34 2712.33 0.00
ioc::network::libos::connect 41.86 15517.40 6535.67 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 14320.00 6184.20 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6367.31 2687.12 28.48
ioc::network::libos::accept 38.43 2809.70 1191.78 0.00
demikernel::async_close 32.50 578.56 228.05 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 23.00 1249.26 560.16 22.97
demikernel::accept 21.86 1088.67 467.93 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 21.34 579.09 243.78 3.44
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 17599.93 7664.75 38.46
demikernel::connect 20.93 2365.31 994.39 0.00
demikernel::socket 10.30 2696.44 1133.34 0.00
bgc::inetstack::arp::background 6.60 2203.55 920.85 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 21058.22 8784.42 95.55
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 18836.75 7855.68 89.20
bgc::inetstack::icmp::background 1.05 4560.12 1955.09 0.00
demikernel::new 1.00 1773304789.28 740977862.49 44.40
bgc::inetstack::poll_recv;inetstack::poll 1.00 44041.20 18374.37 0.13
demikernel::bind 1.00 11367.44 4755.47 0.00
demikernel::listen 1.00 5302.36 2228.26 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 1.00 638.00 243.19 0.76
demikernel::close 0.00 nan nan 0.00

Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iyzhang iyzhang merged commit e0cb130 into dev Nov 7, 2024
14 checks passed
@iyzhang iyzhang deleted the enhancement-inetstack-remove-queue branch November 7, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants