Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Bug Fix: Correctly exit #1454

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[testing] Bug Fix: Correctly exit #1454

merged 1 commit into from
Nov 8, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 6, 2024

This PR fixes an issue in the tcp-echo closed loop client where it never exists if the log interval is set

@iyzhang iyzhang requested a review from anandbonde November 6, 2024 01:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

libos = catnap
commit id = 75a5c27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13171271.31 1940.94 861.77 32.60
demikernel::sgafree 11569.26 79.85 34.66 0.05
demikernel::sgaalloc 11338.68 114.28 49.93 0.10
ioc::network::libos::push;catnap::linux::transport::push 9066.12 781.92 348.21 4.86
ioc::network::libos::push 8800.49 16733.21 7459.90 6.48
demikernel::push 8800.49 535.24 236.98 0.15
ioc::network::libos::pop;catnap::linux::transport::pop 8038.87 538.98 237.44 3.77
ioc::network::libos::pop 7830.00 4439233.74 1802720.16 25.43
demikernel::pop 7830.00 543.35 237.97 0.11
ioc::network::libos::pushto 1901.67 7398.04 3038.53 25.13
ioc::network::libos::pushto;catnap::linux::transport::push 1901.67 520.86 214.53 7.08
demikernel::pushto 1901.67 436.68 179.64 1.52
demikernel::async_close 32.50 915.12 383.58 0.01
ioc::network::libos::connect 24.95 6067052.14 2735203.23 28.06
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 55171.44 24260.39 1.53
demikernel::connect 24.95 2099.77 928.70 0.01
ioc::network::libos::close 18.35 23168.99 10169.60 0.05
ioc::network::libos::close;catnap::linux::transport::close 18.35 22258.36 9771.52 96.25
demikernel::accept 15.42 1282.45 565.66 0.00
ioc::network::libos::accept 15.39 891416032.53 392759398.67 44.50
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2375.52 1055.02 0.00
demikernel::socket 9.50 122958.46 53937.40 0.18
demikernel::socket;catnap::linux::transport::socket 9.50 121555.66 53305.67 97.69
demikernel::new 1.00 255426.41 111962.74 0.08
demikernel::bind 1.00 29002.85 12715.26 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 24016.08 10535.25 82.89
demikernel::listen 1.00 14958.66 6587.25 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13987.13 6161.95 93.42
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

libos = catpowder
commit id = 75a5c27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 19091141.33 684.12 297.65 86.19
bgc::inetstack::poll_recv 9545570.67 1588.95 691.29 52.26
bgc::inetstack::tcp::established::background 23725.55 3970.26 1730.51 0.96
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 23725.55 428.98 187.57 9.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 23716.79 920.30 398.37 23.29
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 23687.36 1016.57 444.01 21.40
bgc::inetstack::tcp::established::background;tcp::established::background::sender 23645.30 1839.47 799.54 36.66
ioc::network::libos::pop 9500.73 999.84 435.12 0.09
demikernel::sgafree 8794.68 103.08 45.57 0.01
ioc::network::libos::push;inetstack::push 8762.74 710.27 312.52 0.22
ioc::network::libos::push 8073.71 33685289.65 15845480.92 42.08
demikernel::push 8073.71 610.98 266.52 0.04
demikernel::sgaalloc 6599.25 147.64 64.74 0.03
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 6103.20 625.59 272.03 0.75
demikernel::pop 6037.49 650.10 280.57 0.04
ioc::network::libos::pushto 1494.33 4372.31 1970.63 5.34
ioc::network::libos::pushto;inetstack::push 1494.33 3859.38 1739.26 88.27
demikernel::pushto 1494.33 487.67 220.06 0.57
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 257.00 216.28 94.84 64.20
ioc::network::libos::close 47.87 6325.20 2763.02 0.09
bgc::passive_listening::poll 43.89 5731.95 2492.76 0.00
ioc::network::libos::connect 41.86 20306.72 8822.66 0.15
bgc::inetstack::tcp::passiveopen::background 41.86 15662.71 6765.64 0.00
ioc::network::libos::accept 39.00 2838.74 1231.74 0.00
demikernel::async_close 32.50 610.08 264.30 0.01
demikernel::accept 21.86 1215.09 533.25 0.00
demikernel::connect 20.93 3748.45 1655.59 0.02
demikernel::socket 10.30 1428.60 623.48 0.00
bgc::inetstack::arp::background 6.35 1723.47 749.23 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5401.20 2353.72 81.71
bgc::inetstack::icmp::background 1.03 3228.52 1404.65 0.00
demikernel::new 1.00 98503897.63 43026891.58 19.56
demikernel::bind 1.00 24768.19 10685.27 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 13133.97 5721.47 0.03
demikernel::listen 1.00 7622.64 3283.04 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

libos = catnip
commit id = 75a5c27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 29518643.70 334.12 140.13 76.99
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 29518643.70 195.58 82.02 58.55
bgc::inetstack::poll_recv 14759321.85 868.50 364.19 33.65
bgc::inetstack::tcp::established::background 22051.16 2771.37 1165.47 0.46
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 22051.16 339.84 143.14 11.44
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 22040.80 614.26 254.05 23.14
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 22009.30 1010.39 425.93 29.46
bgc::inetstack::tcp::established::background;tcp::established::background::sender 21967.36 759.93 316.96 22.51
ioc::network::libos::pop 9045.53 869.68 367.86 0.06
demikernel::sgafree 8779.19 87.29 36.69 0.00
ioc::network::libos::push;inetstack::push 8762.74 651.77 279.16 0.16
ioc::network::libos::push 8073.71 33633220.83 13337294.91 32.32
demikernel::push 8073.71 745.84 313.29 0.02
demikernel::sgaalloc 6534.38 139.76 58.17 0.01
demikernel::pop 6052.14 575.61 241.17 0.01
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 5497.64 395.41 163.78 15.13
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3611.29 759.18 317.44 0.73
ioc::network::libos::pushto 1220.67 1444.62 605.11 0.06
ioc::network::libos::pushto;inetstack::push 1220.67 723.95 303.98 50.25
demikernel::pushto 1220.67 473.41 198.53 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1220.67 254.53 106.64 35.16
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 541.00 258.35 104.81 70.89
ioc::network::libos::close 49.42 6039.49 2535.06 0.01
ioc::network::libos::connect 41.86 15581.79 6568.02 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 15289.17 6659.09 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6327.20 2675.75 28.25
bgc::passive_listening::poll 40.61 6434.13 2766.58 0.00
ioc::network::libos::accept 38.46 2673.62 1139.70 0.00
demikernel::async_close 32.50 590.45 237.89 0.00
demikernel::accept 21.86 1152.22 496.13 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 21.07 565.42 239.37 3.43
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 18458.53 8117.87 37.57
demikernel::connect 20.93 2586.19 1090.43 0.00
demikernel::socket 10.30 1303.79 550.40 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 3256.22 1370.42 37.19
bgc::inetstack::arp::background 6.57 2140.15 901.41 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 19960.93 8364.90 95.48
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 17751.02 7436.82 88.92
bgc::inetstack::icmp::background 1.05 3123.30 1305.81 0.00
demikernel::new 1.00 1768608396.90 741334795.73 45.35
bgc::inetstack::poll_recv;inetstack::poll 1.00 41807.80 17519.93 0.15
demikernel::bind 1.00 11027.25 4645.00 0.00
demikernel::listen 1.00 6744.14 2909.44 0.00
demikernel::close 0.00 nan nan 0.00

anandbonde
anandbonde approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iyzhang iyzhang force-pushed the bugfix-testing-echo branch from 75a5c27 to 534d424 Compare November 8, 2024 18:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

libos = catpowder
commit id = 534d424

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 19029467.80 688.31 298.24 86.12
bgc::inetstack::poll_recv 9514733.90 1599.43 692.92 52.82
bgc::inetstack::tcp::established::background 22046.54 4135.01 1787.84 0.87
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 22046.54 426.91 189.28 8.93
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 22038.09 931.23 392.09 22.67
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 22009.38 1073.49 468.80 21.87
bgc::inetstack::tcp::established::background;tcp::established::background::sender 21967.48 1952.05 831.97 37.21
ioc::network::libos::pop 9095.22 977.97 424.67 0.08
demikernel::sgafree 8898.49 118.01 50.39 0.01
ioc::network::libos::push;inetstack::push 8762.80 711.49 313.10 0.19
ioc::network::libos::push 8073.74 33723110.99 15134570.54 42.50
demikernel::push 8073.74 679.28 293.23 0.04
demikernel::sgaalloc 6700.08 152.65 66.62 0.03
demikernel::pop 6099.43 663.00 281.37 0.03
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5334.63 656.11 282.43 0.72
ioc::network::libos::pushto 3328.00 4555.38 2291.78 6.44
ioc::network::libos::pushto;inetstack::push 3328.00 4013.91 2020.66 88.10
demikernel::pushto 3328.00 505.64 256.69 0.72
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 1310.33 206.74 84.48 62.92
ioc::network::libos::close 47.57 6538.38 2799.46 0.08
bgc::passive_listening::poll 44.39 5629.35 2436.27 0.00
ioc::network::libos::connect 41.86 24961.61 10732.38 0.16
bgc::inetstack::tcp::passiveopen::background 41.86 16317.44 7014.75 0.01
ioc::network::libos::accept 38.93 2835.40 1218.90 0.00
demikernel::async_close 32.50 688.64 285.53 0.01
demikernel::accept 21.86 1406.30 599.14 0.00
demikernel::connect 20.93 4287.51 1840.67 0.02
demikernel::socket 10.30 1536.39 668.45 0.00
bgc::inetstack::arp::background 6.35 1777.72 768.14 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 6560.00 2818.78 83.86
bgc::inetstack::icmp::background 1.03 3575.27 1538.51 0.00
demikernel::new 1.00 98196151.87 42136035.01 18.78
demikernel::bind 1.00 24983.19 10779.00 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 15562.37 6685.31 0.03
demikernel::listen 1.00 5937.14 2553.14 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

libos = catnap
commit id = 534d424

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13457478.73 1936.24 847.30 32.49
demikernel::sgafree 11602.61 81.23 34.98 0.05
demikernel::sgaalloc 11394.08 128.36 56.34 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.12 898.91 394.78 5.36
ioc::network::libos::push 8800.49 17346.39 7622.29 6.35
demikernel::push 8800.49 581.90 254.93 0.15
ioc::network::libos::pop;catnap::linux::transport::pop 8053.64 540.69 235.56 3.38
ioc::network::libos::pop 7844.39 3084235.03 1343211.03 25.39
demikernel::pop 7844.39 533.61 230.15 0.10
ioc::network::libos::pushto 3201.67 7572.43 3283.74 25.14
ioc::network::libos::pushto;catnap::linux::transport::push 3201.67 524.79 227.20 7.04
demikernel::pushto 3201.67 423.38 183.44 1.52
demikernel::async_close 32.50 1009.68 415.77 0.01
ioc::network::libos::connect 24.95 5366651.57 2320356.86 28.36
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 56519.52 25054.33 1.84
demikernel::connect 24.95 2323.69 1031.01 0.01
ioc::network::libos::close 18.35 26597.95 11616.36 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 25456.53 11121.49 95.75
demikernel::accept 15.42 1289.47 561.36 0.00
ioc::network::libos::accept 15.41 905087229.21 391381088.15 44.64
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 2588.22 1127.09 0.00
demikernel::socket 9.50 125574.67 56102.24 0.19
demikernel::socket;catnap::linux::transport::socket 9.50 124243.12 55520.28 97.77
demikernel::new 1.00 258320.63 112270.69 0.12
demikernel::bind 1.00 28833.30 12524.11 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 24280.90 10549.24 84.22
demikernel::listen 1.00 15567.29 6767.41 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14546.05 6324.11 93.32
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

libos = catnip
commit id = 534d424

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 28791928.57 338.54 144.22 77.00
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 28791928.57 198.57 84.68 58.57
bgc::inetstack::poll_recv 14395964.28 879.89 374.96 33.14
bgc::inetstack::tcp::established::background 22157.86 2765.89 1175.98 0.46
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 22157.86 365.76 155.65 11.65
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 22147.50 599.51 250.93 22.71
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 22116.02 1006.76 430.01 29.68
bgc::inetstack::tcp::established::background;tcp::established::background::sender 22074.14 741.36 312.17 22.32
ioc::network::libos::pop 9060.22 926.46 392.18 0.06
demikernel::sgafree 8778.91 90.49 38.63 0.00
ioc::network::libos::push;inetstack::push 8762.74 653.06 283.24 0.16
ioc::network::libos::push 8073.71 33624437.46 14833899.89 32.46
demikernel::push 8073.71 696.74 298.28 0.02
demikernel::sgaalloc 6536.17 134.54 58.47 0.01
demikernel::pop 6050.90 610.96 255.75 0.01
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 5497.64 393.42 164.56 15.17
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 3643.92 737.50 312.24 0.74
ioc::network::libos::pushto 1215.67 1766.12 869.39 0.08
ioc::network::libos::pushto;inetstack::push 1215.67 991.35 494.95 54.84
demikernel::pushto 1215.67 707.62 359.25 0.03
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1215.67 310.15 152.27 32.41
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 491.33 269.93 118.22 70.89
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 76.66 626.67 264.75 3.52
ioc::network::libos::close 49.38 6322.10 2685.66 0.01
ioc::network::libos::connect 41.86 16111.30 6872.33 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 16001.28 6849.10 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6525.42 2782.70 28.54
bgc::passive_listening::poll 40.07 6543.57 2783.15 0.00
ioc::network::libos::accept 38.46 2666.60 1127.58 0.00
demikernel::async_close 32.50 570.32 227.64 0.00
demikernel::accept 21.86 1687.66 718.35 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 19029.71 8175.43 37.76
demikernel::connect 20.93 2681.17 1142.05 0.00
demikernel::socket 10.30 1949.06 835.48 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 9.00 6137.56 2610.08 40.99
bgc::inetstack::arp::background 6.57 2205.99 933.88 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 20516.48 8696.52 95.41
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 18256.08 7737.62 88.98
bgc::inetstack::icmp::background 1.05 3254.48 1374.86 0.00
demikernel::new 1.00 1764166902.20 747442242.83 45.77
bgc::inetstack::poll_recv;inetstack::poll 1.00 43005.67 18228.36 0.14
demikernel::bind 1.00 11296.25 4825.39 0.00
demikernel::listen 1.00 8070.29 3354.41 0.00
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang merged commit 6019bb6 into dev Nov 8, 2024
14 checks passed
@iyzhang iyzhang deleted the bugfix-testing-echo branch November 8, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iyzhang @anandbonde