Expands APIC plugins exception handling

microsoft · May 13, 2024 · 2a6ca02 · 2a6ca02
1 parent adf6d2d
commit 2a6ca02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/dev-proxy-plugins/RequestLogs/ApiCenterOnboardingPlugin.cs b/dev-proxy-plugins/RequestLogs/ApiCenterOnboardingPlugin.cs
@@ -142,11 +142,7 @@ public override void Register(IPluginEvents pluginEvents,
         {
             _ = authenticationHandler.GetAccessToken(CancellationToken.None).Result;
         }
-        catch (Exception ex) when
-            // dev credential
-            (ex is AuthenticationFailedException ||
-            // prod credential
-            ex is AggregateException && ex.InnerException is CredentialUnavailableException)
+        catch (Exception ex)
         {
             _logger?.LogError(ex, "Failed to authenticate with Azure. The {plugin} will not be used.", Name);
             return;

diff --git a/dev-proxy-plugins/RequestLogs/ApiCenterProductionVersionPlugin.cs b/dev-proxy-plugins/RequestLogs/ApiCenterProductionVersionPlugin.cs
@@ -153,11 +153,7 @@ public override void Register(IPluginEvents pluginEvents,
         {
             _ = authenticationHandler.GetAccessToken(CancellationToken.None).Result;
         }
-        catch (Exception ex) when
-            // dev credential
-            (ex is AuthenticationFailedException ||
-            // prod credential
-            ex is AggregateException && ex.InnerException is CredentialUnavailableException)
+        catch (Exception ex)
         {
             _logger?.LogError(ex, "Failed to authenticate with Azure. The {plugin} will not be used.", Name);
             return;