-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): Update V9 Charts to use DataVizGradientPalette #33323
Open
shawn-grant
wants to merge
43
commits into
microsoft:master
Choose a base branch
from
shawn-grant:chart-gradients
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtishayMsft
reviewed
Nov 22, 2024
change/@fluentui-react-charts-preview-d9ff82b5-6274-429e-8f9d-bd400e647d4b.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
📊 Bundle size report✅ No changes found |
PR CI is failing. |
Pull request demo site: URL |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
CI error should be fixed with this commit 0cc5413 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
fabricteam
reviewed
Nov 22, 2024
apps/vr-tests-react-components/src/stories/Charts/DonutChart.stories.tsx
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
AtishayMsft
reviewed
Nov 26, 2024
packages/charts/react-charts-preview/library/src/components/DonutChart/Arc/Arc.types.ts
Outdated
Show resolved
Hide resolved
…types and stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DataVizGradientPalette and rounded corners in v9 charts as default
Modified
New Behavior (UI)
DonutChart
With Custom Gradient
HorizontalBarChart
With Custom Gradient
Notable Changes:
utilities/gradients.ts
color
properties to support gradients intypes/DataPoint.ts
New Usage
TODO
Related
#32008