-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio-group): value handling #33362
Open
olaf-k
wants to merge
10
commits into
microsoft:master
Choose a base branch
from
olaf-k:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+58
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This short PR attempts to fix the radio-group's value setting.
In the current code, inferring a radio-group's initial value from a checked radio child does not work properly:
-1
tabindex)Both of these behaviors stem from the fact that the value setter's logic is not called. This PR corrects that by triggering it in the slot change handler.
I've also taken the opportunity to:
Updates.enqueue
from this handler as it defers the component initialization (first call toradiosChanged
) to the next event loop tick, which is not great UX if authors want to get the value early (e.g., in a whenDefined call).checkRadio()
byradio.click()
in radio-group so that keyboard navigation would also emit the proper events.name
prop).(Not related but, for some reason, there is code that unchecks a radio when it becomes disabled. I'm not sure that's wanted as it is a strange departure from native behavior, so I also removed that.)I reverted the "disabled unchecked" change as I learned the hard way the Fluent component is designed to work this way. (I rewrote the logic for my own component, let me know if you're interested in another PR for that).