Fix accordion icon alignment #33418
Open
Fix accordion icon alignment #33418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
dmytrokirpa
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Hey @vs4vijay, thanks for the PR! Just need to tackle the comment about the storybook stories and then we're good to go.
| @@ -33,3 +33,24 @@ WithIcon.parameters = { | |||
| }, | |||
| }, | |||
| }; | |||
|
|
|||
| export const WithLongHeaderText = () => ( | |||
There was a problem hiding this comment.
We may not need a separate story for this on the storybook website. I suggest verifying if this scenario is already covered by the Visual Regression tests here, and if not, adding this story there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33347