-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for Calendar Compat #33446
Open
gouttierre
wants to merge
1
commit into
master
Choose a base branch
from
gouttierre-patch-updates-calendar-compact
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording removed suggested that a full v9 version was being worked on which created confusion with partners.
gouttierre
added
Fluent UI react-components (v9)
Storybook
Component: Calendar Compat
Calendar Compat component
labels
Dec 11, 2024
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
fabricteam
reviewed
Dec 11, 2024
@@ -28,7 +28,7 @@ yarn workspace @fluentui/react-calendar-compat start | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Avatar Converged.Badge Mask RTL.chromium.png | 2 | Changed |
Avatar Converged.badgeMask.chromium.png | 1 | Changed |
Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Drawer.overlay drawer full.chromium.png | 1154 | Changed |
tudorpopams
approved these changes
Dec 11, 2024
khmakoto
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a change file to pass the failing check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Documentation
Component: Calendar Compat
Calendar Compat component
Fluent UI react-components (v9)
Storybook
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording removed suggested that a full v9 version was being worked on which created confusion with partners.
Previous Behavior
The wording suggested that a full v9 version was being worked on which created confusion with partners.
New Behavior
The wording removed suggested should help remove confusion.
Related Issue(s)