Fixing retry logic to not hit service when Retry-After header returned (

#190)
microsoft · Jun 11, 2018 · 2c72cd9 · 2c72cd9
1 parent 1bcf079
commit 2c72cd9
Showing 1 changed file with 24 additions and 17 deletions.
diff --git a/Source/HTTP/httpcall.cpp b/Source/HTTP/httpcall.cpp
@@ -244,6 +244,20 @@ bool http_call_should_retry(
         }
         if (call->traceCall) { HC_TRACE_INFORMATION(HTTPCLIENT, "HCHttpCallPerformExecute [ID %llu] delayBeforeRetry %lld ms", call->id, call->delayBeforeRetry.count()); }
 
+        // Remember result if there was an error and there was a Retry-After header
+        if (call->retryAfterCacheId != 0 &&
+            retryAfter.count() > 0 &&
+            httpStatus > 400)
+        {
+            auto retryAfterTime = retryAfter + responseReceivedTime;
+            http_retry_after_api_state state(retryAfterTime, httpStatus);
+            auto httpSingleton = get_http_singleton(false);
+            if (httpSingleton)
+            {
+                httpSingleton->set_retry_state(call->retryAfterCacheId, state);
+            }
+        }
+
         if (remainingTimeBeforeTimeout < call->delayBeforeRetry + std::chrono::milliseconds(MIN_HTTP_TIMEOUT_IN_MS))
         {
             // Don't bother retrying when out of time
@@ -259,20 +273,6 @@ bool http_call_should_retry(
             }
         }
 
-        // Remember result if there was an error and there was a Retry-After header
-        if (call->retryAfterCacheId != 0 &&
-            retryAfter.count() > 0 &&
-            httpStatus > 400)
-        {
-            auto retryAfterTime = retryAfter + responseReceivedTime;
-            http_retry_after_api_state state(retryAfterTime, httpStatus);
-            auto httpSingleton = get_http_singleton(false);
-            if (httpSingleton)
-            {
-                httpSingleton->set_retry_state(call->retryAfterCacheId, state);
-            }
-        }
-
         return true;
     }
 
@@ -282,9 +282,12 @@ bool http_call_should_retry(
 bool should_fast_fail(
     _In_ http_retry_after_api_state apiState,
     _In_ HC_CALL* call,
-    _In_ const chrono_clock_t::time_point& currentTime
+    _In_ const chrono_clock_t::time_point& currentTime,
+    _Out_ bool* clearState
     )
 {
+    *clearState = false;
+
     if (apiState.statusCode < 400)
     {
         return false;
@@ -293,6 +296,8 @@ bool should_fast_fail(
     std::chrono::milliseconds remainingTimeBeforeRetryAfterInMS = std::chrono::duration_cast<std::chrono::milliseconds>(apiState.retryAfterTime - currentTime);
     if (remainingTimeBeforeRetryAfterInMS.count() <= 0)
     {
+        // Only clear the API cache when Retry-After time is up
+        *clearState = true;
         return false;
     }
 
@@ -339,13 +344,15 @@ void retry_http_call_until_done(
     http_retry_after_api_state apiState = httpSingleton->get_retry_state(retryContext->call->retryAfterCacheId);
     if (apiState.statusCode >= 400)
     {
-        if (should_fast_fail(apiState, retryContext->call, requestStartTime))
+        bool clearState = false;
+        if (should_fast_fail(apiState, retryContext->call, requestStartTime, &clearState))
         {
             HCHttpCallResponseSetStatusCode(retryContext->call, apiState.statusCode);
             if (retryContext->call->traceCall) { HC_TRACE_INFORMATION(HTTPCLIENT, "HCHttpCallPerformExecute [ID %llu] Fast fail %d", retryContext->call->id, apiState.statusCode); }
             CompleteAsync(retryContext->outerAsyncBlock, S_OK, 0);
         }
-        else
+
+        if( clearState )
         {
             httpSingleton->clear_retry_state(retryContext->call->retryAfterCacheId);
         }