Skip to content

Commit

Permalink
fix mac install failure (#42)
Browse files Browse the repository at this point in the history
* downloaded nupkgs are all lower case
* fix test .nupkgs and assert for proper path in test

Co-authored-by: davidjen@davidjen-mbp <[email protected]>
Co-authored-by: davidjen@DAVIDJENDEV <[email protected]>
  • Loading branch information
3 people authored May 25, 2021
1 parent c9cfac6 commit 7b352a4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/client/lib/CliAcquisition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ export class CliAcquisition implements IDisposable {
case 'win32':
return 'microsoft.powerapps.cli';
case 'darwin':
return 'microsoft.powerapps.cli.Core.osx-x64';
return 'microsoft.powerapps.cli.core.osx-x64';
case 'linux':
return 'microsoft.powerapps.cli.Core.linux-x64';
return 'microsoft.powerapps.cli.core.linux-x64';
default:
throw new Error(`Unsupported OS platform for pac CLI: ${platformName}`);
}
Expand Down
2 changes: 2 additions & 0 deletions src/client/test/unit/CliAcquisition.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ describe('CliAcquisition', () => {
const exePath = await acq.ensureInstalled();

expect(exePath).to.be.not.undefined;
expect(fs.existsSync(path.resolve(exePath, 'pac'))).to.be.true;
expect(spy.infoMessages).to.be.not.empty;
expect(spy.noErrors).to.be.true;
}).timeout(10000);
Expand All @@ -87,6 +88,7 @@ describe('CliAcquisition', () => {
const exePath = await acq.ensureInstalled();

expect(exePath).to.be.not.undefined;
expect(fs.existsSync(path.resolve(exePath, 'pac'))).to.be.true;
expect(spy.infoMessages).to.be.not.empty;
expect(spy.noErrors).to.be.true;
const versionInfo = fs.readJSONSync(trackerFile);
Expand Down
Git LFS file not shown
Git LFS file not shown

0 comments on commit 7b352a4

Please sign in to comment.