Skip to content

Commit

Permalink
changes
Browse files Browse the repository at this point in the history
  • Loading branch information
BidishaMS committed Jan 19, 2024
1 parent 2e2d714 commit a73b346
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 22 deletions.
4 changes: 1 addition & 3 deletions src/web/client/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import { copilotNotificationPanel, disposeNotificationPanel } from "../../common
import { COPILOT_NOTIFICATION_DISABLED } from "../../common/copilot/constants";
import * as Constants from "./common/constants"
import { fetchArtemisResponse } from "../../common/ArtemisService";
import { oneDSLoggerWrapper } from "../../common/OneDSLoggerTelemetry/oneDSLoggerWrapper";

export function activate(context: vscode.ExtensionContext): void {
// setup telemetry
Expand All @@ -56,7 +55,6 @@ export function activate(context: vscode.ExtensionContext): void {
WebExtensionContext.telemetry.getTelemetryReporter()
);

oneDSLoggerWrapper.instantiate();
WebExtensionContext.telemetry.sendInfoTelemetry("activated");
const portalsFS = new PortalsFS();
context.subscriptions.push(
Expand Down Expand Up @@ -593,4 +591,4 @@ async function logArtemisTelemetry() {
logArtemisTelemetry.name,
ARTEMIS_RESPONSE_FAILED);
}
}
}
21 changes: 2 additions & 19 deletions src/web/client/telemetry/webExtensionTelemetry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { sanitizeURL } from "../utilities/urlBuilderUtil";
import { telemetryEventNames } from "./constants";
import { IPortalWebExtensionInitQueryParametersTelemetryData, IWebExtensionAPITelemetryData, IWebExtensionExceptionTelemetryData, IWebExtensionInitPathTelemetryData, IWebExtensionPerfTelemetryData } from "./webExtensionTelemetryInterface";
import { isNullOrUndefined } from '../utilities/commonUtil';
import { oneDSLoggerWrapper } from "../../../common/OneDSLoggerTelemetry/oneDSLoggerWrapper";

export class WebExtensionTelemetry {
private _telemetry: TelemetryReporter | undefined;
Expand All @@ -34,7 +33,6 @@ export class WebExtensionTelemetry {
}
}
this._telemetry?.sendTelemetryEvent(telemetryData.eventName, telemetryData.properties);
oneDSLoggerWrapper.getLogger().traceInfo(telemetryData.eventName, telemetryData.properties)
}

public sendExtensionInitQueryParametersTelemetry(queryParamsMap: Map<string, string>) {
Expand All @@ -56,7 +54,6 @@ export class WebExtensionTelemetry {
}
}
this._telemetry?.sendTelemetryEvent(telemetryData.eventName, telemetryData.properties);
oneDSLoggerWrapper.getLogger().traceInfo(telemetryData.eventName, telemetryData.properties)
}

public sendErrorTelemetry(eventName: string, methodName: string, errorMessage?: string, error?: Error) {
Expand All @@ -72,25 +69,15 @@ export class WebExtensionTelemetry {
telemetryData.properties.stack = error.stack;
}
if (errorMessage || error) {
let error: Error = new Error(errorMessage);
const error: Error = new Error(errorMessage);
this._telemetry?.sendTelemetryException(error, telemetryData.properties);
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
console.log("here eventName--"+eventName);
errorMessage = 'Exception';
console.log("here errorMessage--"+errorMessage);
error = new Error();
console.log("here error--"+error);
// oneDSLoggerWrapper.getLogger().traceError(eventName, errorMessage, error, telemetryData.properties)
} else {
this._telemetry?.sendTelemetryException(new Error(), telemetryData.properties);
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
oneDSLoggerWrapper.getLogger().traceError(eventName, errorMessage!, new Error(), telemetryData.properties)
}
}

public sendInfoTelemetry(eventName: string, properties?: Record<string, string>) {
this._telemetry?.sendTelemetryEvent(eventName, properties);
oneDSLoggerWrapper.getLogger().traceInfo(eventName, properties)
}

public sendAPITelemetry(
Expand Down Expand Up @@ -125,11 +112,8 @@ export class WebExtensionTelemetry {
if (errorMessage) {
const error: Error = new Error(errorMessage);
this._telemetry?.sendTelemetryException(error, { ...telemetryData.properties, eventName: eventName }, telemetryData.measurements);
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
oneDSLoggerWrapper.getLogger().traceError(eventName, errorMessage!, error, { ...telemetryData.properties, eventName: eventName }, telemetryData.measurements)
} else {
this._telemetry?.sendTelemetryEvent(telemetryData.eventName, telemetryData.properties, telemetryData.measurements);
oneDSLoggerWrapper.getLogger().traceInfo(telemetryData.eventName, telemetryData.properties, telemetryData.measurements)
}
}

Expand Down Expand Up @@ -188,10 +172,9 @@ export class WebExtensionTelemetry {
}
}
this._telemetry?.sendTelemetryEvent(telemetryData.eventName, undefined, telemetryData.measurements);
oneDSLoggerWrapper.getLogger().traceInfo(telemetryData.eventName, undefined, telemetryData.measurements)
}

private getPathParameterValue(parameter: string | undefined | null): string {
return (parameter) ? parameter : '';
}
}
}

0 comments on commit a73b346

Please sign in to comment.