Site Runtime Preview Enhancements #1081
Open
+191
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshu92
changed the title
amitjoshi438
approved these changes
Jan 15, 2025
| ppapiEndpoint = "https://api.powerplatform.cn"; | ||
| break; | ||
| // Below endpoints are not supported yet | ||
| case ServiceEndpointCategory.HIGH: |
There was a problem hiding this comment.
Is there a separate endpoint for HIGH?
|
|
||
| const orgDetails = await initializeOrgDetails(false, pacTerminal.getWrapper()); | ||
|
|
||
| progress.report({ message: vscode.l10n.t('Getting region information...') }); |
There was a problem hiding this comment.
Shall we move all the strings to constants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR has the following changes:
Sovereign Cloud Endpoints
PreviewSiteClass Enhancements:loadSiteUrlto fetch and store the website URL.handleEmptyWebsiteUrlto manage the login flow when the website URL is not found.handlePreviewRequestto use the stored website URL and handle initialization messages.extension.tsFile Adjustments:getWorkspaceFoldersutility function for better code reuse.PreviewSitemethods.Other Codebase Improvements:
showProgressNotificationfunction and replaced it withshowProgressWithNotification.AuthenticationProvider.tsby adding service scope mappings for different environments.These changes collectively improve the robustness and user experience of the site preview feature while ensuring the codebase remains clean and maintainable.