Enhance accessibility by improving focus styles and adding ARIA attributes in notification panel #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes in notification panel
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
priyanshu92
approved these changes
Jan 17, 2025
sanxsth
reviewed
Jan 20, 2025
sanxsth
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to improve accessibility and localization in the codebase. The most important changes include adding new localized strings, updating SVG elements for accessibility, and enhancing the structure and semantics of HTML content.
Localization Improvements:
l10n/bundle.l10n.json: Added new localized strings for "Arrow icon" and "Copilot illustration."loc/translations-export/vscode-powerplatform.xlf: Added new translation units for "Arrow icon" and "Copilot illustration." [1] [2]Accessibility Enhancements:
src/common/copilot/assets/scripts/copilot.js: Updated SVG elements witharia-labelledbyattributes and addedtitleelements for better accessibility. [1] [2]src/common/copilot/assets/scripts/copilot.js: Changedspanelements toh4andpelements toh1to improve semantic structure. [1] [2]src/common/copilot/welcome-notification/CopilotNotificationPanel.ts: Addedaria-labelandaria-labelledbyattributes to various elements for better screen reader support.Code Quality Improvements:
src/common/copilot/assets/styles/copilot.css: Modified focus styles for links to improve visibility.