Web Extension: Remove dependency on website preview URL #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitjoshi438
approved these changes
Jan 21, 2025
….com/microsoft/powerplatform-vscode into users/priyanshuag/remove-preview-url
sanxsth
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the validation and handling of website preview URLs in the codebase. The most significant changes include modifying the
validateWebsitePreviewURLfunction to return an object with the URL and its validity status, updating thePowerPagesNavigationProviderclass to use this new validation result, and removing theWEBSITE_PREVIEW_URLquery parameter.Changes to URL validation:
src/web/client/utilities/commonUtil.ts: Modified thevalidateWebsitePreviewURLfunction to return an object withwebsiteUrlandisValidproperties instead of a boolean.Updates to
PowerPagesNavigationProviderclass:src/web/client/webViews/powerPagesNavigationProvider.ts: Updated theisWebsitePreviewURLValidproperty and thepreviewPowerPageSitemethod to use the new validation result object. This ensures that the correct URL and its validity are checked before proceeding.Removal of unused query parameter:
src/web/client/common/constants.ts: Removed theWEBSITE_PREVIEW_URLquery parameter from thequeryParametersenum as it is no longer needed.