[PowerPages][Desktop]Fetch and Add Current Environment to Action Hub Tree #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2025 14:36
amitjoshi438
changed the title
added 2 commits
January 27, 2025 20:59
…environment info retrieval in Actions Hub
priyanshu92
reviewed
Jan 29, 2025
|
|
||
| import { AuthInfo } from "./power-pages/actions-hub/Constants"; | ||
|
|
||
| class AuthManager { |
There was a problem hiding this comment.
Should we rename this to PacAuthManager since it only manager pac auth?
Comment on lines
+6
to
+12
| import { expect } from "chai"; | ||
| import * as sinon from "sinon"; | ||
| import * as vscode from "vscode"; | ||
| import { ActionsHubTreeDataProvider } from "../../../../power-pages/actions-hub/ActionsHubTreeDataProvider"; | ||
| import { oneDSLoggerWrapper } from "../../../../../common/OneDSLoggerTelemetry/oneDSLoggerWrapper"; | ||
| import { Constants } from "../../../../power-pages/actions-hub/Constants"; | ||
| import { EnvironmentGroupTreeItem } from "../../../../power-pages/actions-hub/tree-items/EnvironmentGroupTreeItem"; |
Comment on lines
+37
to
+54
| export interface AuthInfo { | ||
| userType: string; | ||
| cloud: string; | ||
| tenantId: string; | ||
| tenantCountry: string; | ||
| user: string; | ||
| entraIdObjectId: string; | ||
| puid: string; | ||
| userCountryRegion: string; | ||
| tokenExpires: string; | ||
| authority: string; | ||
| environmentGeo: string; | ||
| environmentId: string; | ||
| environmentType: string; | ||
| organizationId: string; | ||
| organizationUniqueName: string; | ||
| organizationFriendlyName: string; | ||
| } |
There was a problem hiding this comment.
I think it's better to move this next to AuthManager.ts since it's applicable at Power Platform level. What do you think?
| oneDSLoggerWrapper.getLogger().traceInfo(Constants.EventNames.ACTIONS_HUB_INITIALIZED); | ||
|
|
||
| return actionsHubTreeDataProvider; |
There was a problem hiding this comment.
Any reason for changing the return type here?
| @@ -9,6 +9,7 @@ import { IEnvironmentInfo } from "../models/IEnvironmentInfo"; | |||
| import { Constants } from "../Constants"; | |||
|
|
|||
| export class EnvironmentGroupTreeItem extends ActionsHubTreeItem { | |||
| environmentInfo: any; | |||
There was a problem hiding this comment.
Any reason for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
ActionsHubTreeDataProviderclass, localization files, and related tests. The most significant updates include adding support for thePacTerminalin theActionsHubTreeDataProvider, updating localization strings, and enhancing error handling and logging.Key Changes:
Enhancements to
ActionsHubTreeDataProvider:initializeActionsHubandActionsHubTreeDataProviderto includePacTerminalas a parameter, enabling the retrieval of environment information. (src/client/extension.ts,src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts) [1] [2] [3]getChildrenmethod to fetch and display environment information, with improved error handling and logging. (src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts)Localization Updates:
bundle.l10n.jsonandvscode-powerplatform.xlf. (l10n/bundle.l10n.json,loc/translations-export/vscode-powerplatform.xlf) [1] [2]Constants.tsto includeNO_ENVIRONMENTS_FOUNDandACTIONS_HUB_CURRENT_ENV_FETCH_FAILEDfor better localization and logging. (src/client/power-pages/actions-hub/Constants.ts)Testing Improvements:
ActionsHubTreeDataProviderto verify initialization, tree item retrieval, error handling, and disposal of disposables. (src/client/test/Integration/power-pages/actions-hub/ActionsHubTreeDataProvider.test.ts)Telemetry Constants:
OrganizationFriendlyNameKeyto the telemetry constants for better identification of organization-friendly names. (src/common/OneDSLoggerTelemetry/telemetryConstants.ts)