[A11y] Fix Screen Reader Issue for Status Messages #1100
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitjoshi438
approved these changes
Jan 28, 2025
priyanshu92
approved these changes
Jan 29, 2025
sanxsth
deleted the
users/ssatheesh/fix_screen_reader_issue_in_copilot_chat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue in the PowerPages copilot chat:
copilot.js: Right now, we are creating the status message div ('thinking') and adding it to the DOM. The screen reader won't read the status since the DOM node is being initialized with the message during the time of creation. Only future updates to the content will be read. Therefore, we are adding an empty div first and then setting the content in the next event loop so that the screen reader detects the change and reads out loud.
Note: Tested on web and desktop versions