Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co-presence worker script added #731

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

ritikramuka
Copy link
Contributor

Co-Presence Worker Script, has a all the event listeners on FRS container to fetch and write back (coming soon) in fluid container.
it also get all the content entity id for a users via his all the connection id

@ritikramuka ritikramuka requested a review from a team as a code owner October 4, 2023 10:50
Copy link
Contributor

@amitjoshi438 amitjoshi438 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritikramuka can you please provide a generic name to worker script as it may be used for integrating other things apart from copresence. Also place it inside src/common folder and the webpack output should also be outside the /web folder.

@tyaginidhi
Copy link
Contributor

@ritikramuka can you please provide a generic name to worker script as it may be used for integrating other things apart from copresence. Also place it inside src/common folder and the webpack output should also be outside the /web folder.

+1 on above request - we will be using the same worker for any web worker needed scripts to be run for web extension - so for now its copresence and copilot related stuff

@ritikramuka
Copy link
Contributor Author

ritikramuka commented Oct 5, 2023

@ritikramuka can you please provide a generic name to worker script as it may be used for integrating other things apart from copresence. Also place it inside src/common folder and the webpack output should also be outside the /web folder.

+1 on above request - we will be using the same worker for any web worker needed scripts to be run for web extension - so for now its copresence and copilot related stuff

  1. what should be location of worker file? will we use it on desktop extension also... as @amitjoshi438 mentioned to place in src/common
  2. I'm not managing webpack output in this PR, but will keep in mind in that PR... if I'm missing anything do let me know
  3. Having multiple workers in the future will be more beneficial than only one worker? Does it decrease load over a single worker?

src/web/client/common/worker/webworker.js Outdated Show resolved Hide resolved
src/web/client/common/worker/webworker.js Outdated Show resolved Hide resolved
src/web/client/common/worker/webworker.js Outdated Show resolved Hide resolved
src/web/client/common/worker/webworker.js Outdated Show resolved Hide resolved
src/web/client/common/worker/webworker.js Outdated Show resolved Hide resolved
@tyaginidhi tyaginidhi merged commit 831eeee into main Oct 18, 2023
6 checks passed
@tyaginidhi tyaginidhi deleted the users/ramukaritik/copresence-worker-script branch October 18, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants