-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS support infra - Introducing ECS feature flag read call via a common module #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microsoft/powerplatform-vscode into users/nityagi/IntroduceECSCalls
amitjoshi438
approved these changes
Nov 23, 2023
petrochuk
previously requested changes
Nov 23, 2023
petrochuk
reviewed
Nov 24, 2023
…re config definition parameters
AbdouMoumen
reviewed
Mar 6, 2024
Co-authored-by: Abdelmoumen Bouabdallah <[email protected]>
Co-authored-by: Abdelmoumen Bouabdallah <[email protected]>
Co-authored-by: Abdelmoumen Bouabdallah <[email protected]>
ashishchoudhary001
approved these changes
Apr 29, 2024
the license text update is out of scope for this PR - rest of the comments are addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module can be consumed for reading the latest feature flags set for a user in both desktop and web extension. The API call will currently honor userId, tenantId, region and tenantId filters. More filters support will be introduced in subsequent PR.
Covered:
Why direct ECS API consumption here: ECS JS library is currently not supported for external repo - so this integration has a go ahead to directly consume the ECS API.
NOTE: AI generated details below this line:
This pull request introduces a new feature configuration system for the project, including the addition of a new
ECSFeaturesClient
class and related utilities. The most significant changes involve the creation of a set of new files in thesrc/common/ecs-features
directory, each of which contributes to the overall functionality of the feature configuration system. Additionally, a minor change was made tosrc/web/client/utilities/commonUtil.ts
.Here is a detailed summary of the changes:
New Constants and Types:
src/common/ecs-features/constants.ts
: Added constants related to the ECS feature system, such asECS_REQUEST_URL_TEMPLATE
andPowerPagesClientName
.New Client for ECS Features:
src/common/ecs-features/ecsFeatureClient.ts
: Introduced theECSFeaturesClient
class, which is responsible for initializing and getting the configuration of ECS features.New Interfaces for ECS Features:
src/common/ecs-features/ecsFeatureFlagFilters.ts
: Added theECSAPIFeatureFlagFilters
interface, which represents the filters used for ECS API feature flags.src/common/ecs-features/ecsFeatureProperties.ts
: Introduced theECSFeatureDefinition
andECSFeatureInfo
interfaces, which represent the properties of an ECS feature. Also added a functioncreateECSFeatureDefinition
to create a feature object based on the feature definition.New Utilities for ECS Features:
src/common/ecs-features/ecsFeatureUtil.ts
: Added utility functions likegetECSRequestURL
andpowerPagesFeatureClient
to support the ECS feature system.Feature Gates:
src/common/ecs-features/ecsFeatureGates.ts
: Defined theEnableMultifileVscodeWeb
feature and its fallback configuration.Minor Change:
src/web/client/utilities/commonUtil.ts
: A line break was added after thegetBackToStudioURL
function.