Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS support infra - Introducing ECS feature flag read call via a common module #778

Merged
merged 37 commits into from
Apr 29, 2024

Conversation

tyaginidhi
Copy link
Contributor

@tyaginidhi tyaginidhi commented Nov 23, 2023

This module can be consumed for reading the latest feature flags set for a user in both desktop and web extension. The API call will currently honor userId, tenantId, region and tenantId filters. More filters support will be introduced in subsequent PR.

Covered:
Why direct ECS API consumption here: ECS JS library is currently not supported for external repo - so this integration has a go ahead to directly consume the ECS API.

NOTE: AI generated details below this line:


This pull request introduces a new feature configuration system for the project, including the addition of a new ECSFeaturesClient class and related utilities. The most significant changes involve the creation of a set of new files in the src/common/ecs-features directory, each of which contributes to the overall functionality of the feature configuration system. Additionally, a minor change was made to src/web/client/utilities/commonUtil.ts.

Here is a detailed summary of the changes:

New Constants and Types:

New Client for ECS Features:

New Interfaces for ECS Features:

New Utilities for ECS Features:

Feature Gates:

Minor Change:

@tyaginidhi tyaginidhi marked this pull request as ready for review November 23, 2023 11:21
@tyaginidhi tyaginidhi requested a review from a team as a code owner November 23, 2023 11:21
src/common/ecs-features/constants.ts Show resolved Hide resolved
src/common/ecs-features/ecsFeatureClient.ts Outdated Show resolved Hide resolved
@tyaginidhi tyaginidhi requested a review from petrochuk November 24, 2023 09:40
@petrochuk petrochuk closed this Nov 28, 2023
@tyaginidhi tyaginidhi reopened this Nov 28, 2023
@tyaginidhi tyaginidhi marked this pull request as draft November 28, 2023 06:16
@tyaginidhi tyaginidhi changed the title Initial ECS support infra - Introducing ECS features read call via a common module ECS support infra - Introducing ECS feature flag read call via a common module Nov 28, 2023
@tyaginidhi tyaginidhi marked this pull request as ready for review February 28, 2024 09:03
@tyaginidhi tyaginidhi requested review from a team as code owners February 28, 2024 09:03
@tyaginidhi tyaginidhi marked this pull request as draft February 28, 2024 09:25
src/common/ecs-features/ecsFeatureClient.ts Outdated Show resolved Hide resolved
src/common/ecs-features/ecsFeatureClient.ts Outdated Show resolved Hide resolved
src/common/ecs-features/ecsFeatureClient.ts Outdated Show resolved Hide resolved
src/common/ecs-features/constants.ts Outdated Show resolved Hide resolved
src/common/ecs-features/ecsFeatureUtil.ts Outdated Show resolved Hide resolved
src/common/ecs-features/ecsFeatureClient.ts Outdated Show resolved Hide resolved
@tyaginidhi tyaginidhi marked this pull request as ready for review April 29, 2024 07:37
@tyaginidhi tyaginidhi enabled auto-merge (squash) April 29, 2024 09:38
@tyaginidhi tyaginidhi dismissed petrochuk’s stale review April 29, 2024 09:48

the license text update is out of scope for this PR - rest of the comments are addressed

@tyaginidhi tyaginidhi merged commit bd923c6 into main Apr 29, 2024
4 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/IntroduceECSCalls branch April 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants