Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search functionality on vscode for web #790

Merged
merged 10 commits into from
Jan 25, 2024

Conversation

ritikramuka
Copy link
Contributor

This PR enable us to do a file search on the files loaded by the extension on the vscode for web. File search can be invoked by quickopen or other extensions.

File.Search.V1.mp4

@tyaginidhi
Copy link
Contributor

Also - before checking in this PR - lets get this reviewed from vscode team - and lets sync with them regarding any special handling needed for extension release for web.

@tyaginidhi tyaginidhi marked this pull request as ready for review January 23, 2024 10:25
@tyaginidhi tyaginidhi requested a review from a team as a code owner January 23, 2024 10:25
@tyaginidhi
Copy link
Contributor

TBD - add telemetry on Search for performance monitoring - post telemetry cluster move

@tyaginidhi tyaginidhi merged commit c87b341 into main Jan 25, 2024
6 checks passed
@tyaginidhi tyaginidhi deleted the users/ramukaritik/fileSearchInVsCodeWeb branch January 25, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants