Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added collaboration option on quick pick #791

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Added collaboration option on quick pick #791

merged 8 commits into from
Jan 11, 2024

Conversation

ritikramuka
Copy link
Contributor

@ritikramuka ritikramuka commented Dec 11, 2023 •
edited
Loading

image image

@ritikramuka ritikramuka marked this pull request as ready for review December 12, 2023 08:42
@ritikramuka ritikramuka requested a review from a team as a code owner December 12, 2023 08:42
vedg
vedg reviewed Dec 13, 2023
View reviewed changes
src/web/client/webViews/QuickPickProvider.ts Show resolved Hide resolved
src/web/client/webViews/QuickPickProvider.ts Show resolved Hide resolved
src/web/client/webViews/QuickPickProvider.ts Show resolved Hide resolved
src/web/client/webViews/QuickPickProvider.ts Show resolved Hide resolved
src/web/client/WebExtensionContext.ts Outdated Show resolved Hide resolved
src/web/client/WebExtensionContext.ts Outdated Show resolved Hide resolved
vedg
vedg approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@vedg vedg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care of nit comments in next PR. also please check into the build failures

@ritikramuka ritikramuka enabled auto-merge (squash) January 11, 2024 06:21
@ritikramuka ritikramuka merged commit 85d4f5e into main Jan 11, 2024
6 checks passed
@ritikramuka ritikramuka deleted the users/ramukaritik/collaboration-in-quick-pick branch January 11, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehcrashxor tehcrashxor tehcrashxor approved these changes

@vedg vedg vedg approved these changes

@amitjoshi438 amitjoshi438 amitjoshi438 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ritikramuka @tehcrashxor @vedg @amitjoshi438 @tyaginidhi