Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Event Interfaces and oneDSLoggerWrapper class #804

Merged
merged 24 commits into from
Jan 11, 2024
Merged

Created Event Interfaces and oneDSLoggerWrapper class #804

merged 24 commits into from
Jan 11, 2024

Conversation

BidishaMS
Copy link
Contributor

@BidishaMS BidishaMS commented Jan 8, 2024 •
edited
Loading

  1. Introduced OneDSLoggerWrapper. This class will acts as an adapter. This class API will be used for sending telemetry events
  2. Introduced IEventTypes interface. I have broken down smaller interfaces which will help us to follow Interface Seggregation Principle(ISP)

@BidishaMS BidishaMS changed the title Users/biddas/client logger wrapper1 [Draft] Users/biddas/client logger wrapper1 Jan 9, 2024
Base automatically changed from users/biddas/clientLoggerWrapper to main January 10, 2024 17:16
@BidishaMS BidishaMS marked this pull request as ready for review January 11, 2024 04:30
@BidishaMS BidishaMS requested a review from a team as a code owner January 11, 2024 04:30
@BidishaMS BidishaMS changed the title [Draft] Users/biddas/client logger wrapper1 Created Event Interfaces and ClientLoggerWrapper class Jan 11, 2024
@BidishaMS BidishaMS changed the title Created Event Interfaces and ClientLoggerWrapper class Created Event Interfaces and oneDSLoggerWrapper class Jan 11, 2024
@BidishaMS BidishaMS enabled auto-merge (squash) January 11, 2024 04:56
@BidishaMS BidishaMS merged commit b0acaa9 into main Jan 11, 2024
6 checks passed
@BidishaMS BidishaMS deleted the users/biddas/clientLoggerWrapper1 branch January 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehcrashxor tehcrashxor tehcrashxor approved these changes

@tyaginidhi tyaginidhi tyaginidhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BidishaMS @tehcrashxor @tyaginidhi