Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key issue: Language server refers to common module files - which in turn is incorrectly referring to desktop client file which were causing import of "vscode" module in Language server code. Importing vscode module in langugae server is not a supported sceanrio - hence a crash here.
This is related to issue #893
Under the line copilot generated text:
This pull request primarily involves refactoring and reorganizing the codebase. The changes include the renaming of a file and the relocation of functions, with modifications to the corresponding import statements. The most significant changes are:
File renaming and function relocation:
src/common/PortalConfigFinder.ts
has been renamed tosrc/common/utilities/PathFinderUtil.ts
and the functionsearchPortalConfigFolder
has been moved to this file. [1] [2]getPortalsOrgURLs
has been moved fromsrc/common/PortalConfigFinder.ts
to a new filesrc/common/utilities/WorkspaceInfoFinderUtil.ts
. [1] [2]Import statement modifications:
src/client/PortalWebView.ts
, the import statement forsearchPortalConfigFolder
has been updated to reflect the new location of the function.src/client/extension.ts
, the import statements forgetPortalsOrgURLs
andworkspaceContainsPortalConfigFolder
have been updated to reflect their new locations. [1] [2]src/server/lib/PortalManifestReader.ts
, the import statement forgetPortalConfigFolderUrl
has been updated to reflect its new location.Minor changes:
src/server/YamlServer.ts
for better code readability.