Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML/YML server crash issue #988

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tyaginidhi
Copy link
Contributor

@tyaginidhi tyaginidhi commented Jul 4, 2024

key issue: Language server refers to common module files - which in turn is incorrectly referring to desktop client file which were causing import of "vscode" module in Language server code. Importing vscode module in langugae server is not a supported sceanrio - hence a crash here.

This is related to issue #893

Under the line copilot generated text:

This pull request primarily involves refactoring and reorganizing the codebase. The changes include the renaming of a file and the relocation of functions, with modifications to the corresponding import statements. The most significant changes are:

File renaming and function relocation:

  • src/common/PortalConfigFinder.ts has been renamed to src/common/utilities/PathFinderUtil.ts and the function searchPortalConfigFolder has been moved to this file. [1] [2]
  • The function getPortalsOrgURLs has been moved from src/common/PortalConfigFinder.ts to a new file src/common/utilities/WorkspaceInfoFinderUtil.ts. [1] [2]

Import statement modifications:

  • In src/client/PortalWebView.ts, the import statement for searchPortalConfigFolder has been updated to reflect the new location of the function.
  • In src/client/extension.ts, the import statements for getPortalsOrgURLs and workspaceContainsPortalConfigFolder have been updated to reflect their new locations. [1] [2]
  • In src/server/lib/PortalManifestReader.ts, the import statement for getPortalConfigFolderUrl has been updated to reflect its new location.

Minor changes:

  • A new line was added in src/server/YamlServer.ts for better code readability.

@tyaginidhi tyaginidhi marked this pull request as ready for review July 4, 2024 09:33
@tyaginidhi tyaginidhi requested review from a team as code owners July 4, 2024 09:33
@tyaginidhi tyaginidhi enabled auto-merge (squash) July 4, 2024 09:51
@tyaginidhi tyaginidhi merged commit 090bdf7 into main Jul 4, 2024
5 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/FixServerCrashIssue branch July 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants