Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating regex to match logs expression #864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Alebmurillo
Copy link

@Alebmurillo Alebmurillo commented Feb 22, 2024

Summary of the Pull Request

This PR aims to solve the Resutls analyzer issue 632 that gets generated by the use of double quotes in the log messages in the network.testing.x.logs, therefore the regex has been modified to include double quotes

PR Checklist

  • Applies to work item: ResultsAnalyzer could not parse request #632
  • CLA signed. If not, go over here and sign.
  • Tests added/passed.
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different approach. Issue number where discussion took place: #xxx

Info on Pull Request

This includes only the Regex change

Validation Steps Performed

Run the results analyzer with a network testing log that has double quotes and single quotes

@Alebmurillo Alebmurillo marked this pull request as ready for review February 23, 2024 18:34
@marina-p
Copy link
Contributor

Hello @Alebmurillo,

I tried this fix on the repro GET request in #632, and did not see any behavior change. Could you please share the snippet of the network log for which your change resolved the exception for you?

Thanks,

Marina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants