Improving GoogleApiKeyValidator #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,8 +61,10 @@ public static string IsValidDynamic(ref string fingerprint, ref string message) | |||
| const string Deleted = "RequestDenied: This API project was not found. This API project may have been deleted or may not be authorized to use this API. You may need to enable the API under APIs in the console)."; | |||
| const string KeyNotAuthorized = "RequestDenied: This API key is not authorized to use this service or API."; | |||
| const string ProjectNotAuthorized = "RequestDenied: This API project is not authorized to use this API."; | |||
| const string IpNotAuthorized = "RequestDenied: This IP, site or mobile application is not authorized to use this API key."; | |||
There was a problem hiding this comment.
IpNotAuthorized [](start = 25, length = 15)
This is not the right change. 'NoMatch' indicates a false positive. Both these conditions indicate that we did in fact find a match and that the key was actually secured in some way. We can't take this change, we can discuss more offline.
There was a problem hiding this comment.
I could add Pass to the ValidationState and in the SearchSkimmer, if we get a pass, we change the kind to pass as well. Should we leave error as warning or should we change as well?
In reply to: 578522731 [](ancestors = 578522731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227