Fixes based on merge from main

microsoft · Oct 15, 2024 · 44e366f · 44e366f
1 parent 1b75ccd
commit 44e366f
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 12 deletions.
diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/ISqliteVectorStoreRecordCollectionFactory.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/ISqliteVectorStoreRecordCollectionFactory.cs
@@ -23,6 +23,5 @@ IVectorStoreRecordCollection<TKey, TRecord> CreateVectorStoreRecordCollection<TK
         DbConnection connection,
         string name,
         VectorStoreRecordDefinition? vectorStoreRecordDefinition)
-        where TKey : notnull
-        where TRecord : class;
+        where TKey : notnull;
 }
diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteKernelBuilderExtensions.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteKernelBuilderExtensions.cs
@@ -63,7 +63,6 @@ public static IKernelBuilder AddSqliteVectorStoreRecordCollection<TKey, TRecord>
         SqliteVectorStoreRecordCollectionOptions<TRecord>? options = default,
         string? serviceId = default)
         where TKey : notnull
-        where TRecord : class
     {
         builder.Services.AddSqliteVectorStoreRecordCollection<TKey, TRecord>(collectionName, options, serviceId);
         return builder;
@@ -87,7 +86,6 @@ public static IKernelBuilder AddSqliteVectorStoreRecordCollection<TKey, TRecord>
         SqliteVectorStoreRecordCollectionOptions<TRecord>? options = default,
         string? serviceId = default)
         where TKey : notnull
-        where TRecord : class
     {
         builder.Services.AddSqliteVectorStoreRecordCollection<TKey, TRecord>(collectionName, connectionString, options, serviceId);
         return builder;

diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteServiceCollectionExtensions.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteServiceCollectionExtensions.cs
@@ -85,7 +85,6 @@ public static IServiceCollection AddSqliteVectorStoreRecordCollection<TKey, TRec
         SqliteVectorStoreRecordCollectionOptions<TRecord>? options = default,
         string? serviceId = default)
         where TKey : notnull
-        where TRecord : class
     {
         services.AddKeyedTransient<IVectorStoreRecordCollection<TKey, TRecord>>(
             serviceId,
@@ -120,7 +119,6 @@ public static IServiceCollection AddSqliteVectorStoreRecordCollection<TKey, TRec
         SqliteVectorStoreRecordCollectionOptions<TRecord>? options = default,
         string? serviceId = default)
         where TKey : notnull
-        where TRecord : class
     {
         services.AddKeyedTransient<IVectorStoreRecordCollection<TKey, TRecord>>(
             serviceId,
@@ -150,7 +148,6 @@ public static IServiceCollection AddSqliteVectorStoreRecordCollection<TKey, TRec
     /// <param name="serviceId">The service id that the registrations should use.</param>
     private static void AddVectorizedSearch<TKey, TRecord>(IServiceCollection services, string? serviceId)
         where TKey : notnull
-        where TRecord : class
     {
         services.AddKeyedTransient<IVectorizedSearch<TRecord>>(
             serviceId,

diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStore.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStore.cs
@@ -42,7 +42,6 @@ public SqliteVectorStore(
     /// <inheritdoc />
     public IVectorStoreRecordCollection<TKey, TRecord> GetCollection<TKey, TRecord>(string name, VectorStoreRecordDefinition? vectorStoreRecordDefinition = null)
         where TKey : notnull
-        where TRecord : class
     {
         if (typeof(TKey) != typeof(string) && typeof(TKey) != typeof(ulong))
         {

diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordCollection.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordCollection.cs
@@ -19,7 +19,6 @@ namespace Microsoft.SemanticKernel.Connectors.Sqlite;
 public sealed class SqliteVectorStoreRecordCollection<TRecord> :
     IVectorStoreRecordCollection<ulong, TRecord>,
     IVectorStoreRecordCollection<string, TRecord>
-    where TRecord : class
 #pragma warning restore CA1711 // Identifiers should not have incorrect
 {
     /// <summary>The name of this database for telemetry purposes.</summary>

diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordCollectionOptions.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordCollectionOptions.cs
@@ -8,7 +8,7 @@ namespace Microsoft.SemanticKernel.Connectors.Sqlite;
 /// <summary>
 /// Options when creating a <see cref="SqliteVectorStoreRecordCollection{TRecord}"/>.
 /// </summary>
-public sealed class SqliteVectorStoreRecordCollectionOptions<TRecord> where TRecord : class
+public sealed class SqliteVectorStoreRecordCollectionOptions<TRecord>
 {
     /// <summary>
     /// Gets or sets an optional custom mapper to use when converting between the data model and the SQLite record.

diff --git a/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordMapper.cs b/dotnet/src/Connectors/Connectors.Memory.Sqlite/SqliteVectorStoreRecordMapper.cs
@@ -11,7 +11,6 @@ namespace Microsoft.SemanticKernel.Connectors.Sqlite;
 /// </summary>
 /// <typeparam name="TRecord">The consumer data model to map to or from.</typeparam>
 internal sealed class SqliteVectorStoreRecordMapper<TRecord> : IVectorStoreRecordMapper<TRecord, Dictionary<string, object?>>
-    where TRecord : class
 {
     /// <summary><see cref="VectorStoreRecordPropertyReader"/> with helpers for reading vector store model properties and their attributes.</summary>
     private readonly VectorStoreRecordPropertyReader _propertyReader;

diff --git a/dotnet/src/IntegrationTests/Connectors/Memory/Sqlite/SqliteVectorStoreFixture.cs b/dotnet/src/IntegrationTests/Connectors/Memory/Sqlite/SqliteVectorStoreFixture.cs
@@ -26,7 +26,6 @@ public SqliteVectorStoreFixture()
     public SqliteVectorStoreRecordCollection<TRecord> GetCollection<TRecord>(
         string collectionName,
         SqliteVectorStoreRecordCollectionOptions<TRecord>? options = default)
-        where TRecord : class
     {
         return new SqliteVectorStoreRecordCollection<TRecord>(
             this.Connection,